Supporting high dpi favicons in Instant Extended.

chrome/renderer/resources/extensions/searchbox_api.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var chrome;
 if (!chrome)
   chrome = {};
 
 if (!chrome.embeddedSearch) {
   chrome.embeddedSearch = new function() {
@@ skipping 315 matching lines @@
 
       function GetMostVisitedItemsWrapper() {
         var mostVisitedItems = GetMostVisitedItems();
         for (var i = 0, item; item = mostVisitedItems[i]; ++i) {
           var title = escapeHTML(item.title);
           var domain = escapeHTML(item.domain);
           // TODO(jered): Delete these Shadow DOM elements once the
           // Google-provided NTP no longer depends on them.
           item.titleElement = SafeWrapMostVisited(title, 140, item.direction);
           item.domainElement = SafeWrapMostVisited(domain, 123);
+          item.faviconUrl = GenerateFaviconUrl(item.rid);

[sreeram, 2013/06/04 22:01:56]

These Shadow DOM elements are going to be removed soon. Given that, I don't see
the point of adding this here. You might as well just add this to the
local_ntp.js or wherever you need to compute it (given that there's no secret
ingredient anyway).

[pedro (no code reviews), 2013/06/07 23:34:21]

The faviconUrl will be used as the background image of a normal div, not a
Shadow DOM one, so I think it makes sense putting this code in here. By doing so
we'll make both the live and local NTPs to support high dpi favicons.

           // These properties are private data and should not be returned to
           // the page. They are only accessible via getMostVisitedItemData().
           item.url = null;
           item.title = null;
           item.domain = null;
           item.direction = null;
         }
         return mostVisitedItems;
       }
 
+      function GenerateFaviconUrl(rid) {
+        return "chrome-search://favicon/size/16@" +
+            window.devicePixelRatio + "x/" + rid;
+      }
+
       // =======================================================================
       //                           Exported functions
       // =======================================================================
       this.__defineGetter__('mostVisited', GetMostVisitedItemsWrapper);
       this.__defineGetter__('themeBackgroundInfo', GetThemeBackgroundInfo);
 
       this.deleteMostVisitedItem = function(restrictedId) {
         DeleteMostVisitedItem(restrictedId);
       };
       this.undoAllMostVisitedDeletions = function() {
         UndoAllMostVisitedDeletions();
       };
       this.undoMostVisitedDeletion = function(restrictedId) {
         UndoMostVisitedDeletion(restrictedId);
       };
       this.navigateContentWindow = function(destination, disposition) {
         NavigateNewTabPage(destination, disposition);
       }
 
       this.onmostvisitedchange = null;
       this.onthemechange = null;
     };
 
     // Export legacy searchbox API.
     // TODO: Remove this when Instant Extended is fully launched.
     chrome.searchBox = this.searchBox;
   };
 }