Supporting high dpi favicons in Instant Extended.

chrome/common/favicon_url_parser.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.

[sreeram, 2013/06/04 22:01:56]

No "(c)".

[pedro (no code reviews), 2013/06/07 23:34:21]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_FAVICON_URL_PARSER_H_
+#define CHROME_COMMON_FAVICON_URL_PARSER_H_
+
+#include "ui/webui/web_ui_util.h"

[sreeram, 2013/06/04 22:01:56]

Remove this include. Instead, add the following:

#include <string>

#include "ui/base/layout.h"

[pedro (no code reviews), 2013/06/07 23:34:21]

Done.

+
+namespace chrome {
+
+// Parses |path|, which should be in the format described at the top of the
+// file "chrome/browser/ui/webui/favicon_source.h". Returns true if |path|
+// could be parsed.

[sreeram, 2013/06/04 22:01:56]

Please also document |icon_types|, |supports_origin_parameter| and |params|.

[pedro (no code reviews), 2013/06/07 23:34:21]

Done.

+bool ParseFaviconPath(const std::string& path,
+                     bool supports_origin_parameter,
+                     int icon_types,
+                     bool* is_icon_url,
+                     std::string* url,
+                     int* size_in_dip,
+                     ui::ScaleFactor* scale_factor,
+                     std::string* params);

[sreeram, 2013/06/04 22:01:56]

Nit: Lines 16-22 should each be indented by one more space.

[pedro (no code reviews), 2013/06/07 23:34:21]

Done.

+
+}  // namespace chrome
+
+#endif  // CHROME_COMMON_FAVICON_URL_PARSER_H_