Supporting high dpi favicons in Instant Extended.

chrome/renderer/resources/extensions/searchbox_api.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var chrome;
 if (!chrome)
   chrome = {};
 
 if (!chrome.embeddedSearch) {
   chrome.embeddedSearch = new function() {
@@ skipping 240 matching lines @@
       native function GetThemeBackgroundInfo();
       native function DeleteMostVisitedItem();
       native function UndoAllMostVisitedDeletions();
       native function UndoMostVisitedDeletion();
       native function NavigateNewTabPage();
       native function IsInputInProgress();
 
       function GetMostVisitedItemsWrapper() {
         var mostVisitedItems = GetMostVisitedItems();
         for (var i = 0, item; item = mostVisitedItems[i]; ++i) {
+          item.faviconUrl = UpdateFaviconUrl(item.renderViewId, item.rid);
           // These properties are private data and should not be returned to
           // the page. They are only accessible via getMostVisitedItemData().
           item.url = null;
           item.title = null;
           item.domain = null;
           item.direction = null;
+          item.renderViewId = null;

[samarth, 2013/06/20 00:31:29]

Might as well also delete item.rid since that's not part of the public api

[pedro (no code reviews), 2013/06/20 22:43:45]

As discussed offline, we actually need the rid, so I'm keeping it.

         }
         return mostVisitedItems;
       }
 
+      function UpdateFaviconUrl(renderViewId, rid) {

[samarth, 2013/06/20 00:31:29]

CreateFaviconUrl or ConstructFaviconUrl

[pedro (no code reviews), 2013/06/20 22:43:45]

Renamed to GenerateThumbnailURL to keep consistency with the names used in
searchbox.cc

+        return "chrome-search://favicon/size/16@" +
+            window.devicePixelRatio + "x/" +
+            renderViewId + "/" + rid;
+      }
+
       // =======================================================================
       //                           Exported functions
       // =======================================================================
       this.__defineGetter__('mostVisited', GetMostVisitedItemsWrapper);
       this.__defineGetter__('themeBackgroundInfo', GetThemeBackgroundInfo);
       this.__defineGetter__('isInputInProgress', IsInputInProgress);
 
       this.deleteMostVisitedItem = function(restrictedId) {
         DeleteMostVisitedItem(restrictedId);
       };
@@ skipping 11 matching lines @@
       this.onthemechange = null;
       this.oninputstart = null;
       this.oninputcancel = null;
     };
 
     // Export legacy searchbox API.
     // TODO: Remove this when Instant Extended is fully launched.
     chrome.searchBox = this.searchBox;
   };
 }