Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1538783003: Revert of [Tracing] Adjust allocation register size for low-end devices (Closed)

Created:
5 years ago by dcheng
Modified:
5 years ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Tracing] Adjust allocation register size for low-end devices (patchset #4 id:60001 of https://codereview.chromium.org/1530583003/ ) Reason for revert: win64 GN builders are broken: e:\b\build\slave\win_x64_gn\build\src\base\trace_event\heap_profiler_allocation_register_unittest.cc(210) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win_x64_gn\build\src\base\trace_event\heap_profiler_allocation_register_unittest.cc(210) : warning C4267: 'argument' : conversion from 'size_t' to 'uint32_t', possible loss of data Original issue's description: > [Tracing] Adjust allocation register size for low-end devices > > This patch limits the size of the allocation register and prevents OOM > errors when running AllocationRegisterTest.OverflowDeathTest on low-end > devices. > > BUG=570242 > > Committed: https://crrev.com/684e479f9a46580b5d5bdcf58944b832f6317dc1 > Cr-Commit-Position: refs/heads/master@{#365905} TBR=primiano@chromium.org,ruuda@google.com,seantopping@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570242

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M base/trace_event/heap_profiler_allocation_register.h View 3 chunks +1 line, -6 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_register.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_register_unittest.cc View 3 chunks +6 lines, -10 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
dcheng
Created Revert of [Tracing] Adjust allocation register size for low-end devices
5 years ago (2015-12-18 09:03:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538783003/1
5 years ago (2015-12-18 09:03:37 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years ago (2015-12-18 09:04:29 UTC) #4
Ruud van Asseldonk
https://codereview.chromium.org/1538783003/diff/1/base/trace_event/heap_profiler_allocation_register_unittest.cc File base/trace_event/heap_profiler_allocation_register_unittest.cc (left): https://codereview.chromium.org/1538783003/diff/1/base/trace_event/heap_profiler_allocation_register_unittest.cc#oldcode210 base/trace_event/heap_profiler_allocation_register_unittest.cc:210: AllocationRegister reg(GetNumCellsPerPage()); It might be simpler to just fix ...
5 years ago (2015-12-18 09:24:28 UTC) #6
Ruud van Asseldonk
5 years ago (2015-12-18 09:28:11 UTC) #7
Message was sent while issue was closed.
On 2015/12/18 09:24:28, Ruud van Asseldonk wrote:
>
https://codereview.chromium.org/1538783003/diff/1/base/trace_event/heap_profi...
> File base/trace_event/heap_profiler_allocation_register_unittest.cc (left):
> 
>
https://codereview.chromium.org/1538783003/diff/1/base/trace_event/heap_profi...
> base/trace_event/heap_profiler_allocation_register_unittest.cc:210:
> AllocationRegister reg(GetNumCellsPerPage());
> It might be simpler to just fix the bug and explicitly cast this to an
uint32_t
> than to do the revert.

Ah, it was conflicting with the other revert, never mind.

Powered by Google App Engine
This is Rietveld 408576698