Reduce CPU usage of download shelf UI. (both MD and pre-MD shelves)

chrome/browser/ui/views/download/download_item_view_md.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_item_view_md.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <vector>
@@ skipping 137 matching lines @@
                                        DownloadShelfView* parent)
     : shelf_(parent),
       status_text_(l10n_util::GetStringUTF16(IDS_DOWNLOAD_STATUS_STARTING)),
       dropdown_state_(NORMAL),
       mode_(NORMAL_MODE),
       dragging_(false),
       starting_drag_(false),
       model_(download_item),
       save_button_(nullptr),
       discard_button_(nullptr),
-      dropdown_button_(nullptr),
+      dropdown_button_(new BarControlButton(this)),
       dangerous_download_label_(nullptr),
       dangerous_download_label_sized_(false),
       disabled_while_opening_(false),
       creation_time_(base::Time::Now()),
       time_download_warning_shown_(base::Time()),
       weak_ptr_factory_(this) {
   DCHECK(download());
   DCHECK(ui::MaterialDesignController::IsModeMaterial());
   download()->AddObserver(this);
   set_context_menu_controller(this);
 
+  AddChildView(dropdown_button_);
+
   LoadIcon();
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   font_list_ =
       rb.GetFontList(ui::ResourceBundle::BaseFont).DeriveWithSizeDelta(1);
   status_font_list_ =
       rb.GetFontList(ui::ResourceBundle::BaseFont).DeriveWithSizeDelta(-2);
 
   body_hover_animation_.reset(new gfx::SlideAnimation(this));
   drop_hover_animation_.reset(new gfx::SlideAnimation(this));
 
   SetAccessibilityFocusable(true);
 
   OnDownloadUpdated(download());
 
-  dropdown_button_ = new BarControlButton(this);
-  AddChildView(dropdown_button_);
   SetDropdownState(NORMAL);
   UpdateColorsFromTheme();
 }
 
 DownloadItemViewMd::~DownloadItemViewMd() {
   StopDownloadProgress();
   download()->RemoveObserver(this);
 
   // ExperienceSampling: If the user took no action to remove the warning
   // before it disappeared, then the user effectively dismissed the download
   // without keeping it.
   if (sampling_event_.get())
     sampling_event_->CreateUserDecisionEvent(ExperienceSamplingEvent::kIgnore);
 }
 
 // Progress animation handlers.
 
 void DownloadItemViewMd::StartDownloadProgress() {
   if (progress_timer_.IsRunning())
     return;
   progress_start_time_ = base::TimeTicks::Now();
-  progress_timer_.Start(
-      FROM_HERE,
-      base::TimeDelta::FromMilliseconds(DownloadShelf::kProgressRateMs),
-      base::Bind(&DownloadItemViewMd::SchedulePaint, base::Unretained(this)));
+  progress_timer_.Start(FROM_HERE, base::TimeDelta::FromMilliseconds(
+                                       DownloadShelf::kProgressRateMs),
+                        base::Bind(&DownloadItemViewMd::ProgressTimerFired,
+                                   base::Unretained(this)));
 }
 
 void DownloadItemViewMd::StopDownloadProgress() {
   if (!progress_timer_.IsRunning())
     return;
   previous_progress_elapsed_ += base::TimeTicks::Now() - progress_start_time_;
   progress_start_time_ = base::TimeTicks();
   progress_timer_.Stop();
 }
 
@@ skipping 14 matching lines @@
 // Update the progress graphic on the icon and our text status label
 // to reflect our current bytes downloaded, time remaining.
 void DownloadItemViewMd::OnDownloadUpdated(DownloadItem* download_item) {
   DCHECK_EQ(download(), download_item);
 
   if (!model_.ShouldShowInShelf()) {
     shelf_->RemoveDownloadView(this);  // This will delete us!
     return;
   }
 
-  if (IsShowingWarningDialog() && !model_.IsDangerous()) {
-    // We have been approved.
-    ClearWarningDialog();
-  } else if (!IsShowingWarningDialog() && model_.IsDangerous()) {
-    ShowWarningDialog();
-    // Force the shelf to layout again as our size has changed.
-    shelf_->Layout();
-    SchedulePaint();
+  if (IsShowingWarningDialog() != model_.IsDangerous()) {
+    ToggleWarningDialog();
   } else {
-    base::string16 status_text = model_.GetStatusText();
     switch (download()->GetState()) {
       case DownloadItem::IN_PROGRESS:
         download()->IsPaused() ? StopDownloadProgress()
                                : StartDownloadProgress();
         LoadIconIfItemPathChanged();
         break;
       case DownloadItem::INTERRUPTED:
         StopDownloadProgress();
         complete_animation_.reset(new gfx::SlideAnimation(this));
         complete_animation_->SetSlideDuration(kInterruptedAnimationDurationMs);
         complete_animation_->SetTweenType(gfx::Tween::LINEAR);
         complete_animation_->Show();
-        SchedulePaint();
         LoadIcon();
         break;
       case DownloadItem::COMPLETE:
         if (model_.ShouldRemoveFromShelfWhenComplete()) {
           shelf_->RemoveDownloadView(this);  // This will delete us!
           return;
         }
         StopDownloadProgress();
         complete_animation_.reset(new gfx::SlideAnimation(this));
         complete_animation_->SetSlideDuration(kCompleteAnimationDurationMs);
         complete_animation_->SetTweenType(gfx::Tween::LINEAR);
         complete_animation_->Show();
-        SchedulePaint();
         LoadIcon();
         break;
       case DownloadItem::CANCELLED:
         StopDownloadProgress();
         if (complete_animation_)
           complete_animation_->Stop();
         LoadIcon();
         break;
       default:
         NOTREACHED();
     }
-    status_text_ = status_text;
+    status_text_ = model_.GetStatusText();
+    SchedulePaint();
   }
 
   base::string16 new_tip = model_.GetTooltipText(font_list_, kTooltipMaxWidth);
   if (new_tip != tooltip_text_) {
     tooltip_text_ = new_tip;
     TooltipTextChanged();
   }
 
   UpdateAccessibleName();
-
-  // We use the parent's (DownloadShelfView's) SchedulePaint, since there
-  // are spaces between each DownloadItemViewMd that the parent is responsible
-  // for painting.
-  shelf_->SchedulePaint();
 }
 
 void DownloadItemViewMd::OnDownloadDestroyed(DownloadItem* download) {
   shelf_->RemoveDownloadView(this);  // This will delete us!
 }
 
 void DownloadItemViewMd::OnDownloadOpened(DownloadItem* download) {
   disabled_while_opening_ = true;
   SetEnabled(false);
   base::MessageLoop::current()->task_runner()->PostDelayedTask(
@@ skipping 166 matching lines @@
 
 void DownloadItemViewMd::ShowContextMenuForView(
     View* source,
     const gfx::Point& point,
     ui::MenuSourceType source_type) {
   ShowContextMenuImpl(gfx::Rect(point, gfx::Size()), source_type);
 }
 
 void DownloadItemViewMd::ButtonPressed(views::Button* sender,
                                        const ui::Event& event) {
-  if (dropdown_button_ && sender == dropdown_button_) {
+  if (sender == dropdown_button_) {
     // TODO(estade): this is copied from ToolbarActionView but should be shared
     // one way or another.
     ui::MenuSourceType type = ui::MENU_SOURCE_NONE;
     if (event.IsMouseEvent())
       type = ui::MENU_SOURCE_MOUSE;
     else if (event.IsKeyEvent())
       type = ui::MENU_SOURCE_KEYBOARD;
     else if (event.IsGestureEvent())
       type = ui::MENU_SOURCE_TOUCH;
     SetDropdownState(PUSHED);
@@ skipping 320 matching lines @@
 
   dropdown_button_->SetIcon(
       new_state == PUSHED ? gfx::VectorIconId::FIND_NEXT
                           : gfx::VectorIconId::FIND_PREV,
       base::Bind(&DownloadItemViewMd::GetTextColor, base::Unretained(this)));
   dropdown_button_->OnThemeChanged();
   dropdown_state_ = new_state;
   SchedulePaint();
 }
 
+void DownloadItemViewMd::ToggleWarningDialog() {
+  if (model_.IsDangerous())
+    ShowWarningDialog();
+  else
+    ClearWarningDialog();
+
+  // We need to load the icon now that the download has the real path.
+  LoadIcon();
+
+  // Force the shelf to layout again as our size has changed.
+  shelf_->Layout();
+  shelf_->SchedulePaint();
+}
+
 void DownloadItemViewMd::ClearWarningDialog() {
   DCHECK(download()->GetDangerType() ==
          content::DOWNLOAD_DANGER_TYPE_USER_VALIDATED);
   DCHECK(mode_ == DANGEROUS_MODE || mode_ == MALICIOUS_MODE);
 
   mode_ = NORMAL_MODE;
   dropdown_state_ = NORMAL;
 
   // ExperienceSampling: User proceeded through the warning.
   if (sampling_event_.get()) {
     sampling_event_->CreateUserDecisionEvent(ExperienceSamplingEvent::kProceed);
     sampling_event_.reset(NULL);
   }
   // Remove the views used by the warning dialog.
   if (save_button_) {
     RemoveChildView(save_button_);
     delete save_button_;
     save_button_ = NULL;
   }
   RemoveChildView(discard_button_);
   delete discard_button_;
   discard_button_ = NULL;
   RemoveChildView(dangerous_download_label_);
   delete dangerous_download_label_;
   dangerous_download_label_ = NULL;
   dangerous_download_label_sized_ = false;
   cached_button_size_.SetSize(0, 0);
 
-  // Set the accessible name back to the status and filename instead of the
-  // download warning.
-  UpdateAccessibleName();
-
   // We need to load the icon now that the download has the real path.
   LoadIcon();
 
-  // Force the shelf to layout again as our size has changed.
-  shelf_->Layout();
-  shelf_->SchedulePaint();
-
-  TooltipTextChanged();
+  dropdown_button_->SetVisible(true);
 }
 
 void DownloadItemViewMd::ShowWarningDialog() {
   DCHECK(mode_ != DANGEROUS_MODE && mode_ != MALICIOUS_MODE);
   time_download_warning_shown_ = base::Time::Now();
   content::DownloadDangerType danger_type = download()->GetDangerType();
   RecordDangerousDownloadWarningShown(danger_type);
 #if defined(FULL_SAFE_BROWSING)
   if (model_.ShouldAllowDownloadFeedback()) {
     safe_browsing::DownloadFeedbackService::RecordEligibleDownloadShown(
@@ skipping 26 matching lines @@
   AddChildView(discard_button_);
 
   base::string16 dangerous_label =
       model_.GetWarningText(font_list_, kTextWidth);
   dangerous_download_label_ = new views::Label(dangerous_label);
   dangerous_download_label_->SetMultiLine(true);
   dangerous_download_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   dangerous_download_label_->SetAutoColorReadabilityEnabled(false);
   AddChildView(dangerous_download_label_);
   SizeLabelToMinWidth();
-  TooltipTextChanged();
+
+  dropdown_button_->SetVisible(false);
 }
 
 gfx::ImageSkia DownloadItemViewMd::GetWarningIcon() {
   switch (download()->GetDangerType()) {
     case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL:
     case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT:
     case content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT:
     case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:
     case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED:
       return gfx::CreateVectorIcon(gfx::VectorIconId::REMOVE_CIRCLE,
@@ skipping 136 matching lines @@
     gfx::SlideAnimation* animation) {
   if (from == NORMAL && to == HOT) {
     animation->Show();
   } else if (from == HOT && to == NORMAL) {
     animation->Hide();
   } else if (from != to) {
     animation->Reset((to == HOT) ? 1.0 : 0.0);
   }
 }
 
+void DownloadItemViewMd::ProgressTimerFired() {
+  // Only repaint for the indeterminate size case. Otherwise, we'll repaint only
+  // when there's an update notified via OnDownloadUpdated().
+  if (model_.PercentComplete() < 0)
+    SchedulePaint();
+}
+
 SkColor DownloadItemViewMd::GetTextColor() {
   return GetTextColorForThemeProvider(GetThemeProvider());
 }
 
 SkColor DownloadItemViewMd::GetDimmedTextColor() {
   return SkColorSetA(GetTextColor(), 0xC7);
 }