base/values.h - Issue 1538743002: Switch to standard integer types in base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.h

Issue 1538743002: Switch to standard integer types in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DEPS roll too Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.h

diff --git a/base/values.h b/base/values.h

index a64f6a8fce03dc3cbb800bdbf8db1a9593363c71..07e5b6c83823df6d1751ad9449b770708abf60b9 100644

--- a/base/values.h

+++ b/base/values.h

@@ -9,7 +9,7 @@

// JavaScript. As such, it is NOT a generalized variant type, since only the

// types supported by JavaScript/JSON are supported.

-// IN PARTICULAR this means that there is no support for int64 or unsigned

+// IN PARTICULAR this means that there is no support for int64_t or unsigned

// numbers. Writing JSON with such types would violate the spec. If you need

// something like this, either use a double or make a string value containing

// the number you want.

@@ -18,6 +18,7 @@

#define BASE_VALUES_H_

#include <stddef.h>

+#include <stdint.h>

#include <iosfwd>

#include <map>

@@ -26,8 +27,8 @@

#include <vector>

#include "base/base_export.h"

-#include "base/basictypes.h"

#include "base/compiler_specific.h"

+#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

#include "base/strings/string16.h"

#include "base/strings/string_piece.h"

« no previous file with comments | « base/value_conversions.cc ('k') | base/values_unittest.cc » ('j') | no next file with comments »