Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: base/metrics/histogram_unittest.cc

Issue 1538743002: Switch to standard integer types in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DEPS roll too Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram_snapshot_manager_unittest.cc ('k') | base/metrics/metrics_hashes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_unittest.cc
diff --git a/base/metrics/histogram_unittest.cc b/base/metrics/histogram_unittest.cc
index daa03981f41eaf00cb7d421ae11c541b9fc0f356..2fadc304415e4fc96b5478bdad712cc2e2a30e21 100644
--- a/base/metrics/histogram_unittest.cc
+++ b/base/metrics/histogram_unittest.cc
@@ -4,8 +4,12 @@
#include "base/metrics/histogram.h"
-#include <climits>
+#include <limits.h>
+#include <stddef.h>
+#include <stdint.h>
+
#include <algorithm>
+#include <climits>
#include <vector>
#include "base/logging.h"
@@ -414,11 +418,11 @@ TEST_F(HistogramTest, HistogramSerializeInfo) {
EXPECT_TRUE(iter.ReadInt(&max));
EXPECT_EQ(64, max);
- int64 bucket_count;
+ int64_t bucket_count;
EXPECT_TRUE(iter.ReadInt64(&bucket_count));
EXPECT_EQ(8, bucket_count);
- uint32 checksum;
+ uint32_t checksum;
EXPECT_TRUE(iter.ReadUInt32(&checksum));
EXPECT_EQ(histogram->bucket_ranges()->checksum(), checksum);
@@ -443,8 +447,8 @@ TEST_F(HistogramTest, CustomHistogramSerializeInfo) {
int i;
std::string s;
- int64 bucket_count;
- uint32 ui32;
+ int64_t bucket_count;
+ uint32_t ui32;
EXPECT_TRUE(iter.ReadInt(&i) && iter.ReadString(&s) && iter.ReadInt(&i) &&
iter.ReadInt(&i) && iter.ReadInt(&i) &&
iter.ReadInt64(&bucket_count) && iter.ReadUInt32(&ui32));
« no previous file with comments | « base/metrics/histogram_snapshot_manager_unittest.cc ('k') | base/metrics/metrics_hashes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698