Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: base/guid_posix.cc

Issue 1538743002: Switch to standard integer types in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DEPS roll too Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/guid.cc ('k') | base/guid_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/guid.h" 5 #include "base/guid.h"
6 6
7 #include <stdint.h>
8
7 #include "base/rand_util.h" 9 #include "base/rand_util.h"
8 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
9 11
10 namespace base { 12 namespace base {
11 13
12 std::string GenerateGUID() { 14 std::string GenerateGUID() {
13 uint64 sixteen_bytes[2] = { base::RandUint64(), base::RandUint64() }; 15 uint64_t sixteen_bytes[2] = {base::RandUint64(), base::RandUint64()};
14 16
15 // Set the GUID to version 4 as described in RFC 4122, section 4.4. 17 // Set the GUID to version 4 as described in RFC 4122, section 4.4.
16 // The format of GUID version 4 must be xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx, 18 // The format of GUID version 4 must be xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx,
17 // where y is one of [8, 9, A, B]. 19 // where y is one of [8, 9, A, B].
18 20
19 // Clear the version bits and set the version to 4: 21 // Clear the version bits and set the version to 4:
20 sixteen_bytes[0] &= 0xffffffffffff0fffULL; 22 sixteen_bytes[0] &= 0xffffffffffff0fffULL;
21 sixteen_bytes[0] |= 0x0000000000004000ULL; 23 sixteen_bytes[0] |= 0x0000000000004000ULL;
22 24
23 // Set the two most significant bits (bits 6 and 7) of the 25 // Set the two most significant bits (bits 6 and 7) of the
24 // clock_seq_hi_and_reserved to zero and one, respectively: 26 // clock_seq_hi_and_reserved to zero and one, respectively:
25 sixteen_bytes[1] &= 0x3fffffffffffffffULL; 27 sixteen_bytes[1] &= 0x3fffffffffffffffULL;
26 sixteen_bytes[1] |= 0x8000000000000000ULL; 28 sixteen_bytes[1] |= 0x8000000000000000ULL;
27 29
28 return RandomDataToGUIDString(sixteen_bytes); 30 return RandomDataToGUIDString(sixteen_bytes);
29 } 31 }
30 32
31 // TODO(cmasone): Once we're comfortable this works, migrate Windows code to 33 // TODO(cmasone): Once we're comfortable this works, migrate Windows code to
32 // use this as well. 34 // use this as well.
33 std::string RandomDataToGUIDString(const uint64 bytes[2]) { 35 std::string RandomDataToGUIDString(const uint64_t bytes[2]) {
34 return StringPrintf("%08X-%04X-%04X-%04X-%012llX", 36 return StringPrintf("%08X-%04X-%04X-%04X-%012llX",
35 static_cast<unsigned int>(bytes[0] >> 32), 37 static_cast<unsigned int>(bytes[0] >> 32),
36 static_cast<unsigned int>((bytes[0] >> 16) & 0x0000ffff), 38 static_cast<unsigned int>((bytes[0] >> 16) & 0x0000ffff),
37 static_cast<unsigned int>(bytes[0] & 0x0000ffff), 39 static_cast<unsigned int>(bytes[0] & 0x0000ffff),
38 static_cast<unsigned int>(bytes[1] >> 48), 40 static_cast<unsigned int>(bytes[1] >> 48),
39 bytes[1] & 0x0000ffffffffffffULL); 41 bytes[1] & 0x0000ffffffffffffULL);
40 } 42 }
41 43
42 } // namespace base 44 } // namespace base
OLDNEW
« no previous file with comments | « base/guid.cc ('k') | base/guid_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698