Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: base/containers/hash_tables_unittest.cc

Issue 1538743002: Switch to standard integer types in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DEPS roll too Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/containers/hash_tables.h ('k') | base/containers/linked_list_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/containers/hash_tables.h" 5 #include "base/containers/hash_tables.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h"
11 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
12 11
13 namespace { 12 namespace {
14 13
15 class HashPairTest : public testing::Test { 14 class HashPairTest : public testing::Test {
16 }; 15 };
17 16
18 #define INSERT_PAIR_TEST(Type, value1, value2) \ 17 #define INSERT_PAIR_TEST(Type, value1, value2) \
19 { \ 18 { \
20 Type pair(value1, value2); \ 19 Type pair(value1, value2); \
21 base::hash_map<Type, int> map; \ 20 base::hash_map<Type, int> map; \
22 map[pair] = 1; \ 21 map[pair] = 1; \
23 } 22 }
24 23
25 // Verify that a hash_map can be constructed for pairs of integers of various 24 // Verify that a hash_map can be constructed for pairs of integers of various
26 // sizes. 25 // sizes.
27 TEST_F(HashPairTest, IntegerPairs) { 26 TEST_F(HashPairTest, IntegerPairs) {
28 typedef std::pair<int16, int16> Int16Int16Pair; 27 typedef std::pair<int16_t, int16_t> Int16Int16Pair;
29 typedef std::pair<int16, int32> Int16Int32Pair; 28 typedef std::pair<int16_t, int32_t> Int16Int32Pair;
30 typedef std::pair<int16, int64> Int16Int64Pair; 29 typedef std::pair<int16_t, int64_t> Int16Int64Pair;
31 30
32 INSERT_PAIR_TEST(Int16Int16Pair, 4, 6); 31 INSERT_PAIR_TEST(Int16Int16Pair, 4, 6);
33 INSERT_PAIR_TEST(Int16Int32Pair, 9, (1 << 29) + 378128932); 32 INSERT_PAIR_TEST(Int16Int32Pair, 9, (1 << 29) + 378128932);
34 INSERT_PAIR_TEST(Int16Int64Pair, 10, 33 INSERT_PAIR_TEST(Int16Int64Pair, 10,
35 (INT64_C(1) << 60) + INT64_C(78931732321)); 34 (INT64_C(1) << 60) + INT64_C(78931732321));
36 35
37 typedef std::pair<int32, int16> Int32Int16Pair; 36 typedef std::pair<int32_t, int16_t> Int32Int16Pair;
38 typedef std::pair<int32, int32> Int32Int32Pair; 37 typedef std::pair<int32_t, int32_t> Int32Int32Pair;
39 typedef std::pair<int32, int64> Int32Int64Pair; 38 typedef std::pair<int32_t, int64_t> Int32Int64Pair;
40 39
41 INSERT_PAIR_TEST(Int32Int16Pair, 4, 6); 40 INSERT_PAIR_TEST(Int32Int16Pair, 4, 6);
42 INSERT_PAIR_TEST(Int32Int32Pair, 9, (1 << 29) + 378128932); 41 INSERT_PAIR_TEST(Int32Int32Pair, 9, (1 << 29) + 378128932);
43 INSERT_PAIR_TEST(Int32Int64Pair, 10, 42 INSERT_PAIR_TEST(Int32Int64Pair, 10,
44 (INT64_C(1) << 60) + INT64_C(78931732321)); 43 (INT64_C(1) << 60) + INT64_C(78931732321));
45 44
46 typedef std::pair<int64, int16> Int64Int16Pair; 45 typedef std::pair<int64_t, int16_t> Int64Int16Pair;
47 typedef std::pair<int64, int32> Int64Int32Pair; 46 typedef std::pair<int64_t, int32_t> Int64Int32Pair;
48 typedef std::pair<int64, int64> Int64Int64Pair; 47 typedef std::pair<int64_t, int64_t> Int64Int64Pair;
49 48
50 INSERT_PAIR_TEST(Int64Int16Pair, 4, 6); 49 INSERT_PAIR_TEST(Int64Int16Pair, 4, 6);
51 INSERT_PAIR_TEST(Int64Int32Pair, 9, (1 << 29) + 378128932); 50 INSERT_PAIR_TEST(Int64Int32Pair, 9, (1 << 29) + 378128932);
52 INSERT_PAIR_TEST(Int64Int64Pair, 10, 51 INSERT_PAIR_TEST(Int64Int64Pair, 10,
53 (INT64_C(1) << 60) + INT64_C(78931732321)); 52 (INT64_C(1) << 60) + INT64_C(78931732321));
54 } 53 }
55 54
56 // Verify that base::hash_set<const char*> compares by pointer value, not as C 55 // Verify that base::hash_set<const char*> compares by pointer value, not as C
57 // strings. 56 // strings.
58 TEST(HashTableTest, CharPointers) { 57 TEST(HashTableTest, CharPointers) {
59 std::string str1("hello"); 58 std::string str1("hello");
60 std::string str2("hello"); 59 std::string str2("hello");
61 base::hash_set<const char*> set; 60 base::hash_set<const char*> set;
62 61
63 set.insert(str1.c_str()); 62 set.insert(str1.c_str());
64 EXPECT_EQ(1u, set.count(str1.c_str())); 63 EXPECT_EQ(1u, set.count(str1.c_str()));
65 EXPECT_EQ(0u, set.count(str2.c_str())); 64 EXPECT_EQ(0u, set.count(str2.c_str()));
66 } 65 }
67 66
68 } // namespace 67 } // namespace
OLDNEW
« no previous file with comments | « base/containers/hash_tables.h ('k') | base/containers/linked_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698