 Chromium Code Reviews
 Chromium Code Reviews Issue 1538663003:
  Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1538663003:
  Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/Source/core/BUILD.gn | 
| diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn | 
| index 315a91b7900934963b2cc8ef625a56382bffe5d9..e6c939a8d3f97269441263ba4d04e933bf2a9972 100644 | 
| --- a/third_party/WebKit/Source/core/BUILD.gn | 
| +++ b/third_party/WebKit/Source/core/BUILD.gn | 
| @@ -581,6 +581,7 @@ group("make_core_generated") { | 
| ":make_core_generated_event_names", | 
| ":make_core_generated_event_target_names", | 
| ":make_core_generated_event_type_names", | 
| + ":make_core_generated_experimental_features", | 
| ":make_core_generated_fetch_initiator_type_names", | 
| ":make_core_generated_html_element_factory", | 
| ":make_core_generated_html_element_lookup_trie", | 
| @@ -989,6 +990,28 @@ action("make_core_generated_html_element_lookup_trie") { | 
| deps = make_core_generated_deps | 
| } | 
| +# "ExperimentalFeatures" action in make_core_generated from GYP. | 
| +action("make_core_generated_experimental_features") { | 
| + script = "../build/scripts/make_experimental_features.py" | 
| + | 
| + inputs = scripts_for_in_files + [ | 
| + "../build/scripts/make_experimental_features.py", | 
| + "../platform/RuntimeEnabledFeatures.in", | 
| + "../build/scripts/templates/ExperimentalFeatures.h.tmpl", | 
| + "../build/scripts/templates/ExperimentalFeatures.idl.tmpl", | 
| 
chasej
2015/12/21 16:33:03
This should be ExperimentalFeatures.cpp.tmpl?
 
iclelland
2015/12/21 17:17:24
Absolutely should. Done.
 | 
| + ] | 
| + outputs = [ | 
| + "$blink_core_output_dir/experiments/ExperimentalFeatures.idl", | 
| 
chasej
2015/12/21 16:33:03
This should be ExperimentalFeatures.cpp?
 
iclelland
2015/12/21 17:17:24
Done.
 | 
| + "$blink_core_output_dir/experiments/ExperimentalFeatures.h", | 
| + ] | 
| + | 
| + args = [ | 
| + rebase_path("../platform/RuntimeEnabledFeatures.in", root_build_dir), | 
| + "--output_dir", | 
| + "$rel_blink_core_gen_dir/experiments", | 
| + ] | 
| +} | 
| + | 
| # The bison rules from make_core_generated. | 
| action_foreach("make_core_generated_bison") { | 
| script = "../build/scripts/rule_bison.py" |