Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.

Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.

BUG=551609
Committed: https://crrev.com/194b30abd21263b4351b9b0eff22153fcf85f25c
Cr-Commit-Position: refs/heads/master@{#366426}

[iclelland, 2015-12-18 16:44:14]

Description was changed from

==========
Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.

BUG=551609
==========

to

==========
Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.

BUG=551609
==========

[iclelland, 2015-12-18 16:44:14]

iclelland@chromium.org changed reviewers:
+ chasej@chromium.org, jbroman@chromium.org

[iclelland, 2015-12-18 16:46:32]

+jbroman -- can you PTAL? This is an attempt at addressing the issues raised in
1514113007, by autogenenerating the code to query the runtime flag, only for
explicitly defined experiments.

[jbroman, 2015-12-21 15:03:51]

lgtm

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.cpp.tmpl
(right):

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.cpp.tmpl:4:
#include "config.h"
warning: config.h will go away soon
(https://code.google.com/p/chromium/issues/detail?id=570234)

[chasej, 2015-12-21 16:33:04]

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/BUILD.gn (right):

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/BUILD.gn:1001:
"../build/scripts/templates/ExperimentalFeatures.idl.tmpl",
This should be ExperimentalFeatures.cpp.tmpl?

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/BUILD.gn:1004:
"$blink_core_output_dir/experiments/ExperimentalFeatures.idl",
This should be ExperimentalFeatures.cpp?

[iclelland, 2015-12-21 17:17:24]

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.cpp.tmpl
(right):

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.cpp.tmpl:4:
#include "config.h"
On 2015/12/21 15:03:51, jbroman wrote:
> warning: config.h will go away soon
> (https://code.google.com/p/chromium/issues/detail?id=570234)

Acknowledged, thanks - I'll keep an eye on that.

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/BUILD.gn (right):

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/BUILD.gn:1001:
"../build/scripts/templates/ExperimentalFeatures.idl.tmpl",
On 2015/12/21 16:33:03, chasej wrote:
> This should be ExperimentalFeatures.cpp.tmpl?

Absolutely should. Done.

https://codereview.chromium.org/1538663003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/BUILD.gn:1004:
"$blink_core_output_dir/experiments/ExperimentalFeatures.idl",
On 2015/12/21 16:33:03, chasej wrote:
> This should be ExperimentalFeatures.cpp?

Done.

[chasej, 2015-12-21 18:08:24]

lgtm

[iclelland, 2015-12-21 18:28:42]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2015-12-21 18:28:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1538663003/#ps20001
(title: "Fix broken GN build dependency")

[commit-bot: I haz the power, 2015-12-21 18:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538663003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538663003/20001

[commit-bot: I haz the power, 2015-12-21 18:45:04]

Description was changed from

==========
Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.

BUG=551609
==========

to

==========
Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.

BUG=551609
==========

[commit-bot: I haz the power, 2015-12-21 18:45:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-21 18:46:23]

Description was changed from

==========
Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.

BUG=551609
==========

to

==========
Add code generation for ExperimentalFeatures class from RuntimeEnabledFeatures.

BUG=551609

Committed: https://crrev.com/194b30abd21263b4351b9b0eff22153fcf85f25c
Cr-Commit-Position: refs/heads/master@{#366426}
==========

[commit-bot: I haz the power, 2015-12-21 18:46:24]

Patchset 2 (id:??) landed as
https://crrev.com/194b30abd21263b4351b9b0eff22153fcf85f25c
Cr-Commit-Position: refs/heads/master@{#366426}

[haraken, 2015-12-24 15:46:51]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-12-24 15:46:51]

LGTM

Maybe we want to reach consensus on the naming of this feature though. We're
currently mixing "experimental framework", "experimental feature", "api
experiment", "experiments" etc.

https://codereview.chromium.org/1538663003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_experimental_features.py
(right):

https://codereview.chromium.org/1538663003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_experimental_features.py:2: #
Copyright (C) 2015 Google Inc. All rights reserved.

Nit: You can use the 3-line copyright.