Issue 1538593003: dart2js cps: Backward redundant null check removal

Issue 1538593003: dart2js cps: Backward redundant null check removal (Closed)

Created:
5 years ago by asgerf

Modified:
5 years ago

Reviewers:
Kevin Millikin (Google), sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Backward redundant null check removal. Removes null checks that are follwed by an instruction which performs the same check. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/6857dc81e7eb009688b7da92dd09d535960ae285

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -13 lines)			Patch
M	pkg/compiler/lib/src/common/names.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
A	pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart	View	1 chunk	+131 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_fragment.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/optimizers.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/task.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

This doesn't do much without an inlining pass to insert a lot of redundant null ...

5 years ago (2015-12-17 18:43:56 UTC) #2

asgerf

5 years ago (2015-12-18 15:57:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6857dc81e7eb009688b7da92dd09d535960ae285 (presubmit successful).