Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1538573005: Revert of Don't set -fvisibility=hidden for iOS Debug in GYP. (Closed)

Created:
5 years ago by baxley
Modified:
5 years ago
Reviewers:
Dirk Pranke, dpranke, mmenke
CC:
chromium-reviews, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't set -fvisibility=hidden for iOS Debug in GYP. (patchset #1 id:1 of https://codereview.chromium.org/1533003002/ ) Reason for revert: fails compile on xcodebuild + device Original issue's description: > Don't set -fvisibility=hidden for iOS Debug in GYP. > > Remove -fvisibility=hidden for Debug configuration on iOS at the > top level (common.gypi), so we don't remove symbols from > dependencies. > > BUG=569073 > > Committed: https://crrev.com/b17fbf8f6b05bd868b1555bcbda50c9dfad1946f > Cr-Commit-Position: refs/heads/master@{#366106} TBR=dpranke@google.com,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=569073 Committed: https://crrev.com/4f8c7cc523c6d1453531b7f0e16cc66c1c4a84fa Cr-Commit-Position: refs/heads/master@{#366107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -27 lines) Patch
M build/common.gypi View 2 chunks +9 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
baxley
Created Revert of Don't set -fvisibility=hidden for iOS Debug in GYP.
5 years ago (2015-12-18 16:45:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538573005/1
5 years ago (2015-12-18 16:46:22 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-18 16:46:23 UTC) #4
mmenke
On 2015/12/18 16:46:23, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years ago (2015-12-18 16:46:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538573005/1
5 years ago (2015-12-18 16:47:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 16:48:08 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4f8c7cc523c6d1453531b7f0e16cc66c1c4a84fa Cr-Commit-Position: refs/heads/master@{#366107}
5 years ago (2015-12-18 16:49:16 UTC) #10
Dirk Pranke
5 years ago (2015-12-18 17:29:25 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698