Have WasmModule free it's own memory.

Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.
Fix several floating point warnings.

Don't setup heap as external, as then the GC can't collect it.

Disable some tests that fail under ASAN.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/879b21a43a8ed6f8890e787edeb155c8aa435659
Cr-Commit-Position: refs/heads/master@{#32948}

[bradn, 2015-12-17 12:19:55]

Description was changed from

==========
Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.

Fix several floating point warnings.

R=ahaas@chromium.org
BUG=
==========

to

==========
Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.
Fix several floating point warnings.

Disable some tests that fail under ASAN.

R=ahaas@chromium.org
BUG=
==========

[bradn, 2015-12-17 12:23:05]

Description was changed from

==========
Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.
Fix several floating point warnings.

Disable some tests that fail under ASAN.

R=ahaas@chromium.org
BUG=
==========

to

==========
Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.
Fix several floating point warnings.

Don't setup heap as external, as then the GC can't collect it.

Disable some tests that fail under ASAN.

R=ahaas@chromium.org
BUG=
==========

[ahaas, 2015-12-17 12:42:00]

lgtm (with small nits)

https://codereview.chromium.org/1538543002/diff/20001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm.cc (right):

https://codereview.chromium.org/1538543002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:264: unsigned int CompileAndAdd(TestingModule*
module) {
(nit) Can we use uint32_t here instead?

[bradn, 2015-12-17 12:56:35]

https://codereview.chromium.org/1538543002/diff/20001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm.cc (right):

https://codereview.chromium.org/1538543002/diff/20001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm.cc:264: unsigned int CompileAndAdd(TestingModule*
module) {
On 2015/12/17 12:42:00, ahaas wrote:
> (nit) Can we use uint32_t here instead?

Done.

[bradn, 2015-12-17 12:58:10]

The CQ bit was checked by bradnelson@google.com

[bradn, 2015-12-17 12:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1538543002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2015-12-17 12:58:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538543002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538543002/40001

[commit-bot: I haz the power, 2015-12-17 13:27:28]

Description was changed from

==========
Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.
Fix several floating point warnings.

Don't setup heap as external, as then the GC can't collect it.

Disable some tests that fail under ASAN.

R=ahaas@chromium.org
BUG=
==========

to

==========
Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.
Fix several floating point warnings.

Don't setup heap as external, as then the GC can't collect it.

Disable some tests that fail under ASAN.

R=ahaas@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2015-12-17 13:27:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-17 13:27:43]

Description was changed from

==========
Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.
Fix several floating point warnings.

Don't setup heap as external, as then the GC can't collect it.

Disable some tests that fail under ASAN.

R=ahaas@chromium.org
BUG=
==========

to

==========
Have WasmModule free it's own memory.

Make WasmModule free it's own memory, avoid mixing stack and
heap allocations in tests. This fixes several memory leaks.

Fix several signed compare issues.
Fix several floating point warnings.

Don't setup heap as external, as then the GC can't collect it.

Disable some tests that fail under ASAN.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/879b21a43a8ed6f8890e787edeb155c8aa435659
Cr-Commit-Position: refs/heads/master@{#32948}
==========

[commit-bot: I haz the power, 2015-12-17 13:27:44]

Patchset 3 (id:??) landed as
https://crrev.com/879b21a43a8ed6f8890e787edeb155c8aa435659
Cr-Commit-Position: refs/heads/master@{#32948}