Issue 1538513002: Fix a bug that items can't be selected in list boxes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1538513002: Fix a bug that items can't be selected in list boxes (Closed)

Created:
5 years ago by jun_fang

Modified:
5 years ago

Reviewers:
Tom Sepez, Lei Zhang

CC:
pdfium-reviews_googlegroups.com, kai_jing

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Fix a bug that items can't be selected in list boxes BUG=pdfium:328 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c5d934dff4c2fa254b445dbf06899bb181df1c12

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jun_fang

This bug was introduced by the commit: https://pdfium.googlesource.com/pdfium/+/8ee79f8f2824d5b7058d49ebb10ced6b001c178e.

5 years ago (2015-12-17 10:52:07 UTC) #2

jun_fang

On 2015/12/17 10:52:07, jun_fang wrote: > This bug was introduced by the commit: > https://pdfium.googlesource.com/pdfium/+/8ee79f8f2824d5b7058d49ebb10ced6b001c178e. ...

5 years ago (2015-12-17 10:55:19 UTC) #3

jun_fang

5 years ago (2015-12-18 02:04:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c5d934dff4c2fa254b445dbf06899bb181df1c12 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages