Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153843004: [WebSocket] Send (request|response)_headers_text to the inspector. (Closed)

Created:
6 years, 10 months ago by yhirano
Modified:
6 years, 10 months ago
Reviewers:
Tom Sepez, Adam Rice
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[WebSocket] Send (request|response)_headers_text to the inspector. BUG=327581 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/browser/renderer_host/websocket_host.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M content/child/websocket_bridge.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/websocket.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/websocket_messages.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
yhirano
6 years, 10 months ago (2014-02-20 04:19:19 UTC) #1
Adam Rice
lgtm
6 years, 10 months ago (2014-02-20 06:09:51 UTC) #2
yhirano
+tsepez for websocket_messages.h
6 years, 10 months ago (2014-02-20 06:30:07 UTC) #3
Tom Sepez
On 2014/02/20 06:30:07, yhirano wrote: > +tsepez for websocket_messages.h Messages LGTM.
6 years, 10 months ago (2014-02-20 18:17:32 UTC) #4
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 10 months ago (2014-02-21 01:48:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/153843004/1
6 years, 10 months ago (2014-02-21 01:50:14 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 02:45:39 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_rel_device_ninja for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device_ninja&number=2951
6 years, 10 months ago (2014-02-21 02:45:39 UTC) #8
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 10 months ago (2014-02-21 03:18:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/153843004/1
6 years, 10 months ago (2014-02-21 03:18:47 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 09:47:10 UTC) #11
Message was sent while issue was closed. 
Change committed as 252526

Powered by Google App Engine
This is Rietveld 408576698