Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1538363003: [Media Router UI] Fix route-details/sink-list view flashing. (Closed)

Created:
5 years ago by imcheng
Modified:
4 years, 11 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router UI] Fix route-details/sink-list view flashing. If the dialog is initially in route-details view, and the route is closed before the 3s startup timer fires, then the dialog will flash between the route-details and sink-list view before settling on sink-list. See bug for details. The fix is to only allow maybeShowRouteDetailsOnOpen to be invoked once, on startup. It is removed from |rebuildRouteMaps_| and is now called from setInitialData. Also removed |localRouteCount_| field from media-router-container since it's no longer needed. BUG=571463 Committed: https://crrev.com/ce8a324e712484eb866dfaa4d9b904de0a68f242 Cr-Commit-Position: refs/heads/master@{#367031}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : rebase #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -30 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 5 chunks +17 lines, -30 lines 0 comments Download
M chrome/browser/resources/media_router/media_router_ui_interface.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_tests.js View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
imcheng
5 years ago (2015-12-21 20:49:25 UTC) #2
apacible
Thanks for investigating! lgtm
5 years ago (2015-12-21 23:36:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538363003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538363003/60001
4 years, 12 months ago (2015-12-28 21:06:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/153715)
4 years, 12 months ago (2015-12-28 22:38:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538363003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538363003/60001
4 years, 12 months ago (2015-12-28 23:03:04 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2015-12-29 00:35:17 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 00:36:08 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ce8a324e712484eb866dfaa4d9b904de0a68f242
Cr-Commit-Position: refs/heads/master@{#367031}

Powered by Google App Engine
This is Rietveld 408576698