Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1538243002: [ES6] Stage sloppy function block scoping (Closed)

Created:
5 years ago by Michael Hablich
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ES6] Stage sloppy function block scoping The Inbox problem got resolved so staging is ok. BUG=v8:3305 LOG=Y R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org Committed: https://crrev.com/4fb5a9ff4f76bab831ceff5e41420e3a2fcd68e2 Cr-Commit-Position: refs/heads/master@{#32992}

Patch Set 1 #

Patch Set 2 : Synced with master #

Patch Set 3 : reenable regex lookbehind #

Patch Set 4 : Fix test expectations #

Patch Set 5 : more expectations fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/flag-definitions.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
Michael Hablich
Inbox problem is resolved. PTAL
5 years ago (2015-12-20 07:46:18 UTC) #1
Dan Ehrenberg
lgtm LGTM. Could you write something in the commit message about how it's OK to ...
5 years ago (2015-12-21 19:15:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538243002/1
5 years ago (2015-12-21 19:20:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/13477) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-21 19:21:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538243002/40001
5 years ago (2015-12-21 19:34:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11761)
5 years ago (2015-12-21 19:51:33 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538243002/60001
5 years ago (2015-12-21 22:05:44 UTC) #17
Michael Hablich
On 2015/12/21 22:05:44, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years ago (2015-12-21 22:06:35 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/10266)
5 years ago (2015-12-21 22:20:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538243002/80001
5 years ago (2015-12-21 22:41:48 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-21 23:07:57 UTC) #25
commit-bot: I haz the power
5 years ago (2015-12-21 23:08:17 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4fb5a9ff4f76bab831ceff5e41420e3a2fcd68e2
Cr-Commit-Position: refs/heads/master@{#32992}

Powered by Google App Engine
This is Rietveld 408576698