Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1538243002:
[ES6] Stage sloppy function block scoping (Closed)
|
Created:
5 years ago by Michael Hablich Modified:
5 years ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[ES6] Stage sloppy function block scoping
The Inbox problem got resolved so staging is ok.
BUG=v8:3305
LOG=Y
R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org
Committed: https://crrev.com/4fb5a9ff4f76bab831ceff5e41420e3a2fcd68e2
Cr-Commit-Position: refs/heads/master@{#32992}
Patch Set 1 #Patch Set 2 : Synced with master #Patch Set 3 : reenable regex lookbehind #Patch Set 4 : Fix test expectations #Patch Set 5 : more expectations fixed #Messages
Total messages: 27 (15 generated)
Inbox problem is resolved. PTAL
Description was changed from ========== [ES6] Stage sloppy function block scoping BUG=v8:3305 R=adamk@chromium.org, littledan@chromium.org ========== to ========== [ES6] Stage sloppy function block scoping BUG=v8:3305 R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org ==========
hablich@chromium.org changed reviewers: + rossberg@chromium.org
lgtm LGTM. Could you write something in the commit message about how it's OK to commit this since Inbox was fixed?
Description was changed from ========== [ES6] Stage sloppy function block scoping BUG=v8:3305 R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org ========== to ========== [ES6] Stage sloppy function block scoping The Inbox problem got resolved so staging is ok. BUG=v8:3305 R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org ==========
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538243002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/13477) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...) v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11758) v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/12361) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
Description was changed from ========== [ES6] Stage sloppy function block scoping The Inbox problem got resolved so staging is ok. BUG=v8:3305 R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org ========== to ========== [ES6] Stage sloppy function block scoping The Inbox problem got resolved so staging is ok. BUG=v8:3305 LOG=Y R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org ==========
The CQ bit was checked by hablich@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/1538243002/#ps40001 (title: "reenable regex lookbehind")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538243002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11761)
The CQ bit was checked by hablich@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538243002/60001
On 2015/12/21 22:05:44, commit-bot: I haz the power wrote: > Dry run: CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1538243002/60001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1538243002/60001 Changed test expectations and started a dry run. Feel free to land it.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
The CQ bit was checked by hablich@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/1538243002/#ps80001 (title: "more expectations fixed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538243002/80001
Message was sent while issue was closed.
Description was changed from ========== [ES6] Stage sloppy function block scoping The Inbox problem got resolved so staging is ok. BUG=v8:3305 LOG=Y R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org ========== to ========== [ES6] Stage sloppy function block scoping The Inbox problem got resolved so staging is ok. BUG=v8:3305 LOG=Y R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [ES6] Stage sloppy function block scoping The Inbox problem got resolved so staging is ok. BUG=v8:3305 LOG=Y R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org ========== to ========== [ES6] Stage sloppy function block scoping The Inbox problem got resolved so staging is ok. BUG=v8:3305 LOG=Y R=adamk@chromium.org, littledan@chromium.org,rossberg@chromium.org Committed: https://crrev.com/4fb5a9ff4f76bab831ceff5e41420e3a2fcd68e2 Cr-Commit-Position: refs/heads/master@{#32992} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/4fb5a9ff4f76bab831ceff5e41420e3a2fcd68e2 Cr-Commit-Position: refs/heads/master@{#32992} |
