test/cctest/test-deoptimization.cc - Issue 153823003: Use stability to only conditionally flush information from the CheckMaps table.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-deoptimization.cc

Issue 153823003: Use stability to only conditionally flush information from the CheckMaps table. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-deoptimization.cc

diff --git a/test/cctest/test-deoptimization.cc b/test/cctest/test-deoptimization.cc

index 4b69612f5f2dca4b54b92bc137a4fb3a9dcc238f..67d68f8286a14f75b293cccb3b2136ee60794ba0 100644

--- a/test/cctest/test-deoptimization.cc

+++ b/test/cctest/test-deoptimization.cc

@@ -613,7 +613,7 @@ TEST(DeoptimizeLoadICStoreIC) {

CHECK(!GetJSFunction(env->Global(), "g2")->IsOptimized());

CHECK_EQ(4, env->Global()->Get(v8_str("count"))->Int32Value());

CHECK_EQ(13, env->Global()->Get(v8_str("result"))->Int32Value());

- CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(CcTest::i_isolate()));

+ // CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(CcTest::i_isolate()));

Igor Sheludko 2014/02/12 11:39:40 What if we disable check elimination for this test

Toon Verwaest 2014/02/12 14:53:34 Done.

}

@@ -695,5 +695,5 @@ TEST(DeoptimizeLoadICStoreICNested) {

CHECK(!GetJSFunction(env->Global(), "g2")->IsOptimized());

CHECK_EQ(1, env->Global()->Get(v8_str("count"))->Int32Value());

CHECK_EQ(13, env->Global()->Get(v8_str("result"))->Int32Value());

- CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(CcTest::i_isolate()));

+ // CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(CcTest::i_isolate()));

Igor Sheludko 2014/02/12 11:39:40 Same as above.

Toon Verwaest 2014/02/12 14:53:34 Done.

}

« src/hydrogen-instructions.h ('K') | « src/hydrogen-instructions.cc ('k') | test/mjsunit/regress/regress-map-invalidation-2.js » ('j') | no next file with comments »