Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 153823003: Use stability to only conditionally flush information from the CheckMaps table. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed last comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | test/cctest/test-deoptimization.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3089 matching lines...) Expand 10 before | Expand all | Expand 10 after
3100 } 3100 }
3101 3101
3102 3102
3103 HCheckMaps* HCheckMaps::New(Zone* zone, 3103 HCheckMaps* HCheckMaps::New(Zone* zone,
3104 HValue* context, 3104 HValue* context,
3105 HValue* value, 3105 HValue* value,
3106 Handle<Map> map, 3106 Handle<Map> map,
3107 CompilationInfo* info, 3107 CompilationInfo* info,
3108 HValue* typecheck) { 3108 HValue* typecheck) {
3109 HCheckMaps* check_map = new(zone) HCheckMaps(value, zone, typecheck); 3109 HCheckMaps* check_map = new(zone) HCheckMaps(value, zone, typecheck);
3110 check_map->Add(map, zone); 3110 check_map->Add(map, info, zone);
3111 if (map->CanOmitMapChecks() && 3111 if (map->CanOmitMapChecks() &&
3112 value->IsConstant() && 3112 value->IsConstant() &&
3113 HConstant::cast(value)->HasMap(map)) { 3113 HConstant::cast(value)->HasMap(map)) {
3114 // TODO(titzer): collect dependent map checks into a list. 3114 // TODO(titzer): collect dependent map checks into a list.
3115 check_map->omit_ = true; 3115 check_map->omit_ = true;
3116 if (map->CanTransition()) { 3116 if (map->CanTransition()) {
3117 map->AddDependentCompilationInfo( 3117 map->AddDependentCompilationInfo(
3118 DependentCode::kPrototypeCheckGroup, info); 3118 DependentCode::kPrototypeCheckGroup, info);
3119 } 3119 }
3120 } 3120 }
(...skipping 1373 matching lines...) Expand 10 before | Expand all | Expand 10 after
4494 break; 4494 break;
4495 case kExternalMemory: 4495 case kExternalMemory:
4496 stream->Add("[external-memory]"); 4496 stream->Add("[external-memory]");
4497 break; 4497 break;
4498 } 4498 }
4499 4499
4500 stream->Add("@%d", offset()); 4500 stream->Add("@%d", offset());
4501 } 4501 }
4502 4502
4503 } } // namespace v8::internal 4503 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | test/cctest/test-deoptimization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698