OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #include "config.h" | |
6 #include "core/html/StableState.h" | |
7 | |
8 #include "wtf/HashSet.h" | |
9 #include "wtf/MainThread.h" | |
10 | |
11 namespace WebCore { | |
12 | |
13 typedef HashSet<StableState::Awaiter*> StableStateAwaiters; | |
14 | |
15 static StableStateAwaiters& stableStateAwaiters() | |
16 { | |
17 DEFINE_STATIC_LOCAL(StableStateAwaiters, stableStateAwaiters, ()); | |
18 return stableStateAwaiters; | |
19 } | |
20 | |
21 static bool isInStableState = false; | |
acolwell GONE FROM CHROMIUM
2014/02/10 22:36:05
nit: Now that we have more than one piece of state
philipj_slow
2014/02/17 11:59:24
Then the call sites would have to say something li
| |
22 | |
23 StableState::Awaiter::~Awaiter() | |
24 { | |
25 ASSERT(isMainThread()); | |
26 stableStateAwaiters().remove(this); | |
27 } | |
28 | |
29 void StableState::await(Awaiter& awaiter) | |
30 { | |
31 ASSERT(isMainThread()); | |
32 ASSERT(!isInStableState); | |
33 stableStateAwaiters().add(&awaiter); | |
34 } | |
35 | |
36 void StableState::provide() | |
37 { | |
38 ASSERT(isMainThread()); | |
39 ASSERT(!isInStableState); | |
40 | |
41 if (stableStateAwaiters().isEmpty()) | |
42 return; | |
43 | |
44 isInStableState = true; | |
45 | |
46 StableStateAwaiters awaiters; | |
47 awaiters.swap(stableStateAwaiters()); | |
acolwell GONE FROM CHROMIUM
2014/02/10 22:36:05
Can't this cause a use-after-free if executing did
philipj_slow
2014/02/17 11:59:24
Yes, indeed it can. Since the callbacks aren't run
| |
48 for (StableStateAwaiters::iterator it = awaiters.begin(); it != awaiters.end (); ++it) | |
49 (*it)->didAwaitStableState(); | |
50 | |
51 isInStableState = false; | |
52 } | |
53 | |
54 } // namespace WebCore | |
OLD | NEW |