Support "await a stable state" and "provide a stable state"

Source/core/frame/DOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 52 matching lines @@
 #include "core/frame/Frame.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/History.h"
 #include "core/frame/Location.h"
 #include "core/frame/Navigator.h"
 #include "core/frame/PageConsole.h"
 #include "core/frame/Screen.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLFrameOwnerElement.h"
+#include "core/html/StableState.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/inspector/ScriptCallStack.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/FrameLoadRequest.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/FrameLoaderClient.h"
 #include "core/loader/SinkDocument.h"
 #include "core/loader/appcache/ApplicationCache.h"
 #include "core/page/BackForwardClient.h"
 #include "core/page/Chrome.h"
@@ skipping 922 matching lines @@
 
     FrameHost* host = m_frame->host();
     if (!host)
         return;
 
     if (m_frame->loader().documentLoader()->isLoading()) {
         m_shouldPrintWhenFinishedLoading = true;
         return;
     }
     m_shouldPrintWhenFinishedLoading = false;
+
+    // http://whatwg.org/html#pause
+    StableState::provide();
+
     host->chrome().print(m_frame);
 }
 
 void DOMWindow::stop()
 {
     if (!m_frame)
         return;
     m_frame->loader().stopAllLoaders();
 }
 
 void DOMWindow::alert(const String& message)
 {
     if (!m_frame)
         return;
 
     m_frame->document()->updateStyleIfNeeded();
 
     FrameHost* host = m_frame->host();
     if (!host)
         return;
 
+    // http://whatwg.org/html#pause
+    StableState::provide();

[acolwell GONE FROM CHROMIUM, 2014/02/10 22:36:05]

nit: You should probably find a good home for the pause concept and make a call
to that here and elsewhere. I think that would make it easier to update the
pause logic in the future if necessary.

[philipj_slow, 2014/02/11 17:25:21]

Yeah, I started looking for a place and a name but couldn't find one so I gave
up. I don't think it's very important to provide a stable state here, see
https://www.w3.org/Bugs/Public/show_bug.cgi?id=24484#c2

Since it creates an extra testing effort (that can't be automated cross-browser
because the dialogs are blocking) maybe I should push harder to have "await a
stable state" dropped from "pause"? Even if the spec doesn't change, we can just
wait with implementing this bit until some other browser does first. Yes?

+
     host->chrome().runJavaScriptAlert(m_frame, message);
 }
 
 bool DOMWindow::confirm(const String& message)
 {
     if (!m_frame)
         return false;
 
     m_frame->document()->updateStyleIfNeeded();
 
     FrameHost* host = m_frame->host();
     if (!host)
         return false;
 
+    // http://whatwg.org/html#pause
+    StableState::provide();
+
     return host->chrome().runJavaScriptConfirm(m_frame, message);
 }
 
 String DOMWindow::prompt(const String& message, const String& defaultValue)
 {
     if (!m_frame)
         return String();
 
     m_frame->document()->updateStyleIfNeeded();
 
     FrameHost* host = m_frame->host();
     if (!host)
         return String();
 
+    // http://whatwg.org/html#pause
+    StableState::provide();
+
     String returnValue;
     if (host->chrome().runJavaScriptPrompt(m_frame, message, defaultValue, returnValue))
         return returnValue;
 
     return String();
 }
 
 bool DOMWindow::find(const String& string, bool caseSensitive, bool backwards, bool wrap, bool /*wholeWord*/, bool /*searchInFrames*/, bool /*showDialog*/) const
 {
     if (!isCurrentlyDisplayedInFrame())
@@ skipping 816 matching lines @@
     return static_cast<DOMWindowLifecycleNotifier&>(LifecycleContext<DOMWindow>::lifecycleNotifier());
 }
 
 PassOwnPtr<LifecycleNotifier<DOMWindow> > DOMWindow::createLifecycleNotifier()
 {
     return DOMWindowLifecycleNotifier::create(this);
 }
 
 
 } // namespace WebCore