Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Source/core/html/StableState.cpp

Issue 153813002: Support "await a stable state" and "provide a stable state" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: disallow await during provide Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "config.h"
6 #include "core/html/StableState.h"
7
8 #include "wtf/HashSet.h"
9
10 namespace WebCore {
11
12 typedef HashSet<StableState::Awaiter*> StableStateAwaiters;
13
14 static StableStateAwaiters& stableStateAwaiters()
15 {
16 DEFINE_STATIC_LOCAL(StableStateAwaiters, stableStateAwaiters, ());
acolwell GONE FROM CHROMIUM 2014/02/07 19:09:31 Do we really want this process global? Shouldn't t
philipj_slow 2014/02/09 17:10:17 In the spec these concepts are not scoped per docu
17 return stableStateAwaiters;
18 }
19
20 StableState::Awaiter::~Awaiter()
21 {
22 stableStateAwaiters().remove(this);
23 }
24
25 void StableState::await(Awaiter& awaiter)
26 {
27 stableStateAwaiters().add(&awaiter);
acolwell GONE FROM CHROMIUM 2014/02/07 19:09:31 nit: I wonder if we should keep a bool that keeps
philipj_slow 2014/02/09 17:10:17 Done.
28 }
29
30 void StableState::provide()
31 {
32 if (!stableStateAwaiters().isEmpty()) {
acolwell GONE FROM CHROMIUM 2014/02/07 19:09:31 nit: Reverse condition and early return.
philipj_slow 2014/02/09 17:10:17 Done.
33 StableStateAwaiters awaiters;
34 awaiters.swap(stableStateAwaiters());
35 for (StableStateAwaiters::iterator it = awaiters.begin(); it != awaiters .end(); ++it)
36 (*it)->didAwaitStableState();
37 ASSERT(stableStateAwaiters().isEmpty());
38 }
39 }
40
41 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698