Adding CRWWebViewContentView as a subview when it is set

Adding CRWWebViewContentView as a subview when it is set

Adding subviews in layoutSubviews is problematic
(see http://stackoverflow.com/questions/34301366/call-addsubview-within-layoutsubviews/34301753)

This CL moves it out of |layoutSubviews| and
into when the CRWWebViewContentView is actually
set on the ContainerView.

The existing logic will take care of removing
the old ContentView from the superview
when there is a need to replace the
ContentView.

As a (intended) side effect this CL fixes a bug in UIWebView
 where adding it as part of layoutSubViews would lead to issues
in scrolling of certain pages.

BUG=568097
TEST=
Illustrated in the bug.

Review URL: https://codereview.chromium.org/1531593002

Cr-Commit-Position: refs/heads/master@{#365691}
(cherry picked from commit f5406c826d16602ce699bdf7f7da5cc5461be7f0)

Committed: https://chromium.googlesource.com/chromium/src/+/2127544e6eea33df2b28db1d9335a1c32bba3224

[shreyasv1, 2015-12-18 21:36:06]

Description was changed from

==========
Adding CRWWebViewContentView as a subview when it is set

Adding subviews in layoutSubviews is problematic
(see
http://stackoverflow.com/questions/34301366/call-addsubview-within-layoutsubv...)

This CL moves it out of |layoutSubviews| and
into when the CRWWebViewContentView is actually
set on the ContainerView.

The existing logic will take care of removing
the old ContentView from the superview
when there is a need to replace the
ContentView.

As a (intended) side effect this CL fixes a bug in UIWebView
 where adding it as part of layoutSubViews would lead to issues
in scrolling of certain pages.

BUG=568097
TEST=
Illustrated in the bug.

Review URL: https://codereview.chromium.org/1531593002

Cr-Commit-Position: refs/heads/master@{#365691}
(cherry picked from commit f5406c826d16602ce699bdf7f7da5cc5461be7f0)
==========

to

==========
Adding CRWWebViewContentView as a subview when it is set

Adding subviews in layoutSubviews is problematic
(see
http://stackoverflow.com/questions/34301366/call-addsubview-within-layoutsubv...)

This CL moves it out of |layoutSubviews| and
into when the CRWWebViewContentView is actually
set on the ContainerView.

The existing logic will take care of removing
the old ContentView from the superview
when there is a need to replace the
ContentView.

As a (intended) side effect this CL fixes a bug in UIWebView
 where adding it as part of layoutSubViews would lead to issues
in scrolling of certain pages.

BUG=568097
TEST=
Illustrated in the bug.

Review URL: https://codereview.chromium.org/1531593002

Cr-Commit-Position: refs/heads/master@{#365691}
(cherry picked from commit f5406c826d16602ce699bdf7f7da5cc5461be7f0)

Committed:
https://chromium.googlesource.com/chromium/src/+/2127544e6eea33df2b28db1d9335...
==========

[shreyasv1, 2015-12-18 21:36:07]

Committed patchset #1 (id:1) manually as
2127544e6eea33df2b28db1d9335a1c32bba3224.