Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 153803006: Makes Wiget::OnNativeWidgetMove() be invoked during a maximize (Closed)

Created:
6 years, 10 months ago by sky
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

Makes Wiget::OnNativeWidgetMove() be invoked during a maximize A maximize animation triggers recreating the layer of the window. Recreating the layer forces the bounds of the window to 0. A maximize results in the origin going to 0. Together this meant a maximize from any where resulted in the code not thinking a move happened. This patch special cases NativeWidgetAura::OnBoundsChanged to assume that if the old bounds was empty at 0,0 and the new bounds is not empty that a move happened. BUG=335486 TEST=covered by test R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M ui/views/widget/native_widget_aura.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 2 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 10 months ago (2014-02-04 17:10:24 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2014-02-05 00:44:41 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 10 months ago (2014-02-05 00:59:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/153803006/1
6 years, 10 months ago (2014-02-05 03:52:28 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 07:47:48 UTC) #5
Message was sent while issue was closed.
Change committed as 248908

Powered by Google App Engine
This is Rietveld 408576698