Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: src/objects-inl.h

Issue 153803003: Correctly recognize external strings. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/api.cc ('K') | « src/api.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index dd3c0b182d616fda37b0c66d24acba52e2593570..4b51fa3d9f9d2e3bf20d1bbf8a515aa63d74ff68 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -433,9 +433,6 @@ bool StringShape::IsExternalAscii() {
}
-STATIC_CHECK((kExternalStringTag | kOneByteStringTag) ==
- Internals::kExternalAsciiRepresentationTag);
-
STATIC_CHECK(v8::String::ASCII_ENCODING == kOneByteStringTag);
@@ -444,6 +441,13 @@ bool StringShape::IsExternalTwoByte() {
}
+STATIC_CHECK(kConsStringTag == Internals::kConsRepresentationTag);
+
+STATIC_CHECK((kConsStringTag | kTwoByteStringTag) ==
+ Internals::kConsTwoByteRepresentationTag);
+
+STATIC_CHECK(kExternalStringTag == Internals::kExternalRepresentationTag);
+
STATIC_CHECK((kExternalStringTag | kTwoByteStringTag) ==
Internals::kExternalTwoByteRepresentationTag);
« src/api.cc ('K') | « src/api.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698