Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153803002: Implement GCController::CollectAll (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kouhei (in TOK), hajimehoshi, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Implement GCController::CollectAll One GC cycle is not enough to collect DOM wrappers. To test that all DOM wrappers are reclaimed, this CL adds a function that triggers multiple GC cycles. BUG=307614 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/shell/renderer/gc_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/gc_controller.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
haraken
PTAL Once this CL lands, I'll remove duplicate GC calls from layout tests. e.g., https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/plugins/npruntime/leak-window-scriptable-object.html&q=leak-window-scriptable-object.html&sq=package:chromium&type=cs&l=13
6 years, 10 months ago (2014-02-04 13:33:38 UTC) #1
dcarney
lgtm
6 years, 10 months ago (2014-02-04 14:59:16 UTC) #2
haraken
On 2014/02/04 14:59:16, dcarney wrote: > lgtm Thanks. jochen: would you take a look as ...
6 years, 10 months ago (2014-02-04 15:15:44 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-04 15:26:34 UTC) #4
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-04 15:44:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/153803002/1
6 years, 10 months ago (2014-02-04 15:44:44 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:27:22 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223286
6 years, 10 months ago (2014-02-04 16:27:24 UTC) #8
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 16:27:32 UTC) #9
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-04 16:29:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/153803002/1
6 years, 10 months ago (2014-02-04 16:30:26 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:54:07 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120949
6 years, 10 months ago (2014-02-04 17:54:08 UTC) #13
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-05 00:53:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/153803002/1
6 years, 10 months ago (2014-02-05 03:46:47 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 08:25:17 UTC) #16
Message was sent while issue was closed. 
Change committed as 248918

Powered by Google App Engine
This is Rietveld 408576698