Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 15380004: Add two new WebSocket histograms to track adoption of the permessage-deflate extension. (Closed)

Created:
7 years, 7 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things), SteveT, Alexei Svitkine (slow)
Visibility:
Public.

Description

Add two new WebSocket histograms to track adoption of the permessage-deflate extension. WebCore.WebSocket.HandshakeResult provides baseline by counting the number of WebSocket handshake attempts for each results. WebCore.WebSocket.PerMessageDeflateContextTakeOverMode tells us how many WebSocket connections are established with the permessage-deflate extension turned on including the value of the no_context_takeover extension parameter. BUG=128156 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 7 months ago (2013-05-20 09:12:58 UTC) #1
tyoshino (SeeGerritForStatus)
Histogram definition change https://codereview.chromium.org/15451002/
7 years, 7 months ago (2013-05-20 09:14:07 UTC) #2
tyoshino (SeeGerritForStatus)
On 2013/05/20 09:14:07, tyoshino wrote: > Histogram definition change > https://codereview.chromium.org/15451002/ Sorry, this is actually ...
7 years, 7 months ago (2013-05-20 09:14:47 UTC) #3
jar (doing other things)
lgtm
7 years, 7 months ago (2013-05-20 16:22:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/15380004/1
7 years, 7 months ago (2013-05-21 01:09:31 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 09:19:03 UTC) #6
Message was sent while issue was closed.
Change committed as 201277

Powered by Google App Engine
This is Rietveld 408576698