Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1537973002: MIPS: Fix uninitialized upper word bits for Cvt_d_uw macro. (Closed)

Created:
5 years ago by ivica.bogosavljevic
Modified:
5 years ago
Reviewers:
Ilija.Pavlovic1, djordje.pesic, balazs.kilvady, miran.karic, ilija.pavlovic, Alan Li, akos.palfi.imgtec, paul.l...
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix uninitialized upper word bits for Cvt_d_uw macro. After Cvt_d_uw macro, upper 32 bits of the output remain unitnitialized which caused flaky failures on some tests on MIPS32R6 TEST=cctest/test-assembler-mips/MIPS13,mjsunit/asm/int32-umod BUG= Committed: https://crrev.com/108d52645a56fa068b21cda304e7f23675956b54 Cr-Commit-Position: refs/heads/master@{#32983}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -0 lines 1 comment Download
M test/cctest/test-assembler-mips.cc View 1 chunk +33 lines, -35 lines 1 comment Download

Messages

Total messages: 16 (8 generated)
ivica.bogosavljevic
https://codereview.chromium.org/1537973002/diff/1/src/mips/macro-assembler-mips.cc File src/mips/macro-assembler-mips.cc (right): https://codereview.chromium.org/1537973002/diff/1/src/mips/macro-assembler-mips.cc#newcode1272 src/mips/macro-assembler-mips.cc:1272: mtc1(rs, scratch); After mtc1, upper 32 bits of the ...
5 years ago (2015-12-18 15:07:56 UTC) #3
paul.l...
lgtm
5 years ago (2015-12-21 06:20:45 UTC) #4
Ilija.Pavlovic1
lgtm
5 years ago (2015-12-21 08:56:06 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537973002/1
5 years ago (2015-12-21 09:52:53 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-21 10:15:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537973002/1
5 years ago (2015-12-21 10:47:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 10:49:20 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-21 10:49:46 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/108d52645a56fa068b21cda304e7f23675956b54
Cr-Commit-Position: refs/heads/master@{#32983}

Powered by Google App Engine
This is Rietveld 408576698