Issue 153793002: Tests and fixes for (pre)parse errors related to future reserved words.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153793002: Tests and fixes for (pre)parse errors related to future reserved words. (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Tests and fixes for (pre)parse errors related to future reserved words. This contains the following fixes: - PreParser was using an error "reserved_word" which doesn't exist in messages.js. Changed it to "unexpected_reserved". BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19076

Patch Set 1 #

Patch Set 2 : better tests #

Patch Set 3 : tiny variable rename #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -264 lines)			Patch
	M	src/preparser.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	test/cctest/test-parsing.cc	View	1 2	2 chunks	+153 lines, -262 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

marja

ulan, ptal. This one is less complex than the previous ones.

6 years, 10 months ago (2014-02-04 13:07:25 UTC) #1

marja

6 years, 10 months ago (2014-02-04 16:38:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r19076 (presubmit successful).

Expand Messages | Collapse Messages