Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1537923002: Revert of Create a hash table from id<-->key in SkImageFilter::CacheImpl (Closed)

Created:
5 years ago by reed1
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Create a hash table from id<-->key in SkImageFilter::CacheImpl (patchset #7 id:120001 of https://codereview.chromium.org/1514893003/ ) Reason for revert: speculative revert to try to unblock DEPS roll https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/94665 Original issue's description: > Create a hash table from id<-->key in SkImageFilter::CacheImpl > > There is memory leak in the SkImageFilter::Cache. There are two sources > of memory leak: > 1. The cache filling up quickly. > 2. A slow small leak that never stops. > This CL solves the first issue, which prevents the cache filling up quickly. > This CL creates a new hash table that index the > SkImageFilter::uniqueID to an array of keys, and with the existing > key<-->Value hash table, we can have SkImageFilters proactively > purge content derived cached content when destroyed. > > BUG=489543 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1514893003 > > Committed: https://skia.googlesource.com/skia/+/f5d1f8dcc841516d7ea63c151b13059af40ca76d TBR=mtklein@google.com,junov@chromium.org,xidachen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489543 Committed: https://skia.googlesource.com/skia/+/e848ff59651e4441b2c303ef14db10fd678cee9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -29 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 5 chunks +5 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of Create a hash table from id<-->key in SkImageFilter::CacheImpl
5 years ago (2015-12-18 13:22:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537923002/1
5 years ago (2015-12-18 13:23:05 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-18 13:23:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e848ff59651e4441b2c303ef14db10fd678cee9f

Powered by Google App Engine
This is Rietveld 408576698