Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 1537903004: [arm64] Improve some new builtins. (Closed)

Created:
5 years ago by jbramley
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Improve some new builtins. - Simplify the variable-length pop sequence on entry. (It now uses smaller code with no branches.) - Use conditional compare to merge branches where appropriate. - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more efficiently. - Only load 'undefined' and 'null' once per builtin. - A few other small improvements. BUG= Committed: https://crrev.com/efc641a7be54978cd85a4dcdf1950cd97725917d Cr-Commit-Position: refs/heads/master@{#32975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -152 lines) Patch
M src/arm64/builtins-arm64.cc View 7 chunks +215 lines, -152 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jbramley
This merges our implementation of issue 1523753002 with yours, hopefully getting the best of both.
5 years ago (2015-12-18 15:58:01 UTC) #2
jbramley
By the way, I'll be on holiday for a couple of weeks, so in my ...
5 years ago (2015-12-18 15:59:02 UTC) #3
Benedikt Meurer
Nice. LGTM.
5 years ago (2015-12-18 20:16:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537903004/1
5 years ago (2015-12-18 20:16:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 20:52:12 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/efc641a7be54978cd85a4dcdf1950cd97725917d Cr-Commit-Position: refs/heads/master@{#32975}
5 years ago (2015-12-18 20:52:54 UTC) #9
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1539073002/ by machenbach@chromium.org. ...
5 years ago (2015-12-19 07:54:47 UTC) #10
jbramley
4 years, 11 months ago (2016-01-05 11:31:23 UTC) #11
Message was sent while issue was closed.
Sorry, we'd assumed that we'd never see more than 2 arguments, but these
functions seem to use kDontAdaptArgumentsSentinel so they don't get adapted.

I'll look into it and make a new CL.

Powered by Google App Engine
This is Rietveld 408576698