Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1537903003: Revert of Add visualbench as valid target to Makefile (Closed)

Created:
5 years ago by joshualitt
Modified:
5 years ago
Reviewers:
borenet, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add visualbench as valid target to Makefile (patchset #2 id:20001 of https://codereview.chromium.org/1530233005/ ) Reason for revert: might be breaking cmakebot Original issue's description: > Add visualbench as valid target to Makefile > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1530233005 > > Committed: https://skia.googlesource.com/skia/+/13221b83663778a2f5cbd90e51e253268755877e TBR=borenet@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/034389f4a4fd0fec4fc4c44056283c3ff399a54e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Makefile View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
joshualitt
Created Revert of Add visualbench as valid target to Makefile
5 years ago (2015-12-18 15:29:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537903003/1
5 years ago (2015-12-18 15:29:37 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-18 15:29:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/034389f4a4fd0fec4fc4c44056283c3ff399a54e

Powered by Google App Engine
This is Rietveld 408576698