appengine/cmd/dm/mutate/add_finished_deps.go - Issue 1537883002: Initial distributor implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/dm/mutate/add_finished_deps.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: fix imports and make dummy.go a real file Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cmd/dm/mutate/add_finished_deps.go

diff --git a/appengine/cmd/dm/mutate/add_finished_deps.go b/appengine/cmd/dm/mutate/add_finished_deps.go

index 1e31fc287d74af1989e1ff3d892d2a27c3db2db2..42490ac5d7865398371a6e33f44266572f582b46 100644

--- a/appengine/cmd/dm/mutate/add_finished_deps.go

+++ b/appengine/cmd/dm/mutate/add_finished_deps.go

@@ -28,7 +28,7 @@ type AddFinishedDeps struct {

// Root implements tumble.Mutation

func (f *AddFinishedDeps) Root(c context.Context) *datastore.Key {

- return datastore.Get(c).KeyForObj(&model.Attempt{ID: *f.Auth.Id.AttemptID()})

+ return model.AttemptKeyFromID(c, f.Auth.Id.AttemptID())

}

// RollForward implements tumble.Mutation

@@ -49,7 +49,7 @@ func (f *AddFinishedDeps) RollForward(c context.Context) (muts []tumble.Mutation

muts = append(muts, &AddBackDep{Dep: d.Edge()})

}

for _, q := range f.MergeQuests {

- muts = append(muts, &MergeQuest{q})

+ muts = append(muts, &MergeQuest{Quest: q})

}

return muts, datastore.Get(c).Put(fwdDeps)