common/api/dm/service/v1/attempt_state_evolve_test.go - Issue 1537883002: Initial distributor implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/api/dm/service/v1/attempt_state_evolve_test.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: self review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/cmd/dm/mutate/timeout_execution.go ('K') | « common/api/dm/service/v1/attempt_state_evolve.go ('k') | common/api/dm/service/v1/claim_execution.proto » ('j') | common/api/dm/service/v1/graph_data.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: common/api/dm/service/v1/attempt_state_evolve_test.go

diff --git a/common/api/dm/service/v1/attempt_state_evolve_test.go b/common/api/dm/service/v1/attempt_state_evolve_test.go

index 45bd2ad7f5ff1f63c13f9eb5a67b4ef1acee6b27..ab99a56605fefff24c72b253efc43c55e92e2ee6 100644

--- a/common/api/dm/service/v1/attempt_state_evolve_test.go

+++ b/common/api/dm/service/v1/attempt_state_evolve_test.go

@@ -16,32 +16,32 @@ func TestAttemptState(t *testing.T) {

Convey("Evolve", t, func() {

Convey("Identity", func() {

- s := Attempt_NEEDS_EXECUTION

- So(s.Evolve(Attempt_NEEDS_EXECUTION), ShouldBeNil)

- So(s, ShouldEqual, Attempt_NEEDS_EXECUTION)

+ s := Attempt_SCHEDULING

+ So(s.Evolve(Attempt_SCHEDULING), ShouldBeNil)

+ So(s, ShouldEqual, Attempt_SCHEDULING)

})

Convey("Transition", func() {

s := Attempt_EXECUTING

- So(s.Evolve(Attempt_ADDING_DEPS), ShouldBeNil)

- So(s, ShouldEqual, Attempt_ADDING_DEPS)

+ So(s.Evolve(Attempt_WAITING), ShouldBeNil)

+ So(s, ShouldEqual, Attempt_WAITING)

})

Convey("Invalid starting transistion", func() {

- s := Attempt_NEEDS_EXECUTION

- So(s.Evolve(Attempt_FINISHED), ShouldErrLike, "invalid state transition NEEDS_EXECUTION -> FINISHED")

- So(s, ShouldEqual, Attempt_NEEDS_EXECUTION)

+ s := Attempt_SCHEDULING

+ So(s.Evolve(Attempt_FINISHED), ShouldErrLike, "invalid state transition SCHEDULING -> FINISHED")

+ So(s, ShouldEqual, Attempt_SCHEDULING)

})

Convey("Invalid ending transistion", func() {

- s := Attempt_BLOCKED

- So(s.Evolve(Attempt_FINISHED), ShouldErrLike, "invalid state transition BLOCKED -> FINISHED")

- So(s, ShouldEqual, Attempt_BLOCKED)

+ s := Attempt_WAITING

+ So(s.Evolve(Attempt_FINISHED), ShouldErrLike, "invalid state transition WAITING -> FINISHED")

+ So(s, ShouldEqual, Attempt_WAITING)

})

Convey("MustEvolve", func() {

s := Attempt_FINISHED

- So(func() { s.MustEvolve(Attempt_NEEDS_EXECUTION) }, ShouldPanic)

+ So(func() { s.MustEvolve(Attempt_SCHEDULING) }, ShouldPanic)

})

}