Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: appengine/cmd/dm/mutate/add_backdep.go

Issue 1537883002: Initial distributor implementation (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: self review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/cmd/dm/mutate/add_backdep.go
diff --git a/appengine/cmd/dm/mutate/add_backdep.go b/appengine/cmd/dm/mutate/add_backdep.go
index 2274a4d28178256280351c4e94a146339b7250f6..c86faab422570b1fee94a0b1cd2715e90c8b4e1d 100644
--- a/appengine/cmd/dm/mutate/add_backdep.go
+++ b/appengine/cmd/dm/mutate/add_backdep.go
@@ -43,11 +43,8 @@ func (a *AddBackDep) RollForward(c context.Context) (muts []tumble.Mutation, err
err = ds.Put(bd)
- if a.NeedsAck {
- muts = append(muts, &AckFwdDep{
- Dep: a.Dep,
- DepIsFinished: bdg.AttemptFinished,
- })
+ if a.NeedsAck && bdg.AttemptFinished {
+ muts = append(muts, &AckFwdDep{a.Dep})
}
return
}

Powered by Google App Engine
This is Rietveld 408576698