Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1537853002: - Do not attempt to run dart:io based tests in the browser. (Closed)

Created:
5 years ago by Ivan Posva
Modified:
5 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Do not attempt to run dart:io based tests in the browser. BUG= Committed: https://github.com/dart-lang/sdk/commit/21a029f89ad54cad4467293fb619bef9989005bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
TBR
5 years ago (2015-12-17 23:50:01 UTC) #2
Ivan Posva
Committed patchset #1 (id:1) manually as 21a029f89ad54cad4467293fb619bef9989005bd (presubmit successful).
5 years ago (2015-12-17 23:50:12 UTC) #4
floitsch
5 years ago (2015-12-18 09:48:04 UTC) #5
Message was sent while issue was closed.
LGTM.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698