Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1537833002: - Fix or simplify use of Platform.packageRoot. (Closed)

Created:
5 years ago by Ivan Posva
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Fix or simplify use of Platform.packageRoot. BUG= Committed: https://github.com/dart-lang/sdk/commit/c9d23b0418d9d543476f51f1951343e5583f99dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M tests/compiler/dart2js/analyze_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors/mirrors_test_helper.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Ivan Posva
TBR
5 years ago (2015-12-17 21:52:55 UTC) #2
Ivan Posva
5 years ago (2015-12-17 21:54:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9d23b0418d9d543476f51f1951343e5583f99dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698