Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: components/metrics/metrics_provider.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: addressed final review comments by Alexei Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_pref_names.cc ('k') | components/metrics/metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_provider.h
diff --git a/components/metrics/metrics_provider.h b/components/metrics/metrics_provider.h
index c0571954688e60de0074692916763b18d4f510ba..664e5dbc539299c9e9682378901e558ff723aa81 100644
--- a/components/metrics/metrics_provider.h
+++ b/components/metrics/metrics_provider.h
@@ -7,6 +7,10 @@
#include "base/macros.h"
+namespace base {
+class HistogramSnapshotManager;
+} // namespace base
+
namespace metrics {
class ChromeUserMetricsExtension;
@@ -66,6 +70,13 @@ class MetricsProvider {
virtual void ProvideGeneralMetrics(
ChromeUserMetricsExtension* uma_proto);
+ // Called during collection to explicitly load histogram snapshots using a
+ // snapshot manager. PrepareDeltas() will have already been called and
+ // FinishDeltas() will be called later; calls to only PrepareDelta(), not
+ // PrepareDeltas (plural), should be made.
+ virtual void RecordHistogramSnapshots(
+ base::HistogramSnapshotManager* snapshot_manager);
+
private:
DISALLOW_COPY_AND_ASSIGN(MetricsProvider);
};
« no previous file with comments | « components/metrics/metrics_pref_names.cc ('k') | components/metrics/metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698