Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/installer/setup/installer_metrics.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: move AccessResult to .h and add histogram to .xml Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/installer_metrics.h
diff --git a/chrome/installer/setup/installer_metrics.h b/chrome/installer/setup/installer_metrics.h
new file mode 100644
index 0000000000000000000000000000000000000000..7510b984c4b336a8b477bf1204c3ab191f48e7ae
--- /dev/null
+++ b/chrome/installer/setup/installer_metrics.h
@@ -0,0 +1,25 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_INSTALLER_SETUP_INSTALLER_METRICS_H_
+#define CHROME_INSTALLER_SETUP_INSTALLER_METRICS_H_
+
+namespace base {
+class FilePath;
+} // namespace base
+
+namespace installer {
+
+// Creates a persistent space for any histograms that can be reported later
+// by the browser process.
+void BeginPersistentHistogramStorage();
+
+// Saves all the persistent histograms to a single file on disk for reading
+// by the browser so it can be reported.
Alexei Svitkine (slow) 2016/02/19 18:16:40 Nit: Can you expand the comment to indicate whethe
bcwhite 2016/02/19 19:50:14 Done.
+void EndPersistentHistogramStorage(const base::FilePath& target_dir);
+
+} // namespace installer
+
+#endif // CHROME_INSTALLER_SETUP_INSTALLER_METRICS_H_
+

Powered by Google App Engine
This is Rietveld 408576698