base/metrics/statistics_recorder_unittest.cc - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/statistics_recorder_unittest.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: addressed review comments by Greg Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/metrics/statistics_recorder.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | components/metrics/file_metrics_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/metrics/statistics_recorder_unittest.cc

diff --git a/base/metrics/statistics_recorder_unittest.cc b/base/metrics/statistics_recorder_unittest.cc

index 3e19ec33d5bb051a756cf65631cbeb616c8d7ae9..17511a4d4ffa5ea7d57131b743300c08a8708308 100644

--- a/base/metrics/statistics_recorder_unittest.cc

+++ b/base/metrics/statistics_recorder_unittest.cc

@@ -31,7 +31,7 @@ class StatisticsRecorderTest : public testing::Test {

void TearDown() override {

UninitializeStatisticsRecorder();

- SetPersistentHistogramMemoryAllocator(nullptr);

+ delete ReleasePersistentHistogramMemoryAllocatorForTesting();

}

void InitializeStatisticsRecorder() {