base/metrics/histogram_persistence.h - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_persistence.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: addressed review comments by Greg Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_persistence.h

diff --git a/base/metrics/histogram_persistence.h b/base/metrics/histogram_persistence.h

index 1683713013305aa3ff64da438de11ed704ff88ef..63977c0ff9d07d4339bdba36b4a879514fc83e5d 100644

--- a/base/metrics/histogram_persistence.h

+++ b/base/metrics/histogram_persistence.h

@@ -35,7 +35,7 @@ BASE_EXPORT PersistentMemoryAllocator* GetPersistentHistogramMemoryAllocator();

// within persistent memory segments which can then be extracted and used

// in other ways.

BASE_EXPORT PersistentMemoryAllocator*

-ReleasePersistentHistogramMemoryAllocator();

+ReleasePersistentHistogramMemoryAllocatorForTesting();

// Recreate a Histogram from data held in persistent memory. Though this

// object will be local to the current process, the sample data will be

« no previous file with comments | « no previous file | base/metrics/histogram_persistence.cc » ('j') | components/metrics/file_metrics_provider.h » ('J')