Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1884)

Unified Diff: components/metrics/file_metrics_provider.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: addressed review comments by Greg Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/file_metrics_provider.cc
diff --git a/components/metrics/file_metrics_provider.cc b/components/metrics/file_metrics_provider.cc
new file mode 100644
index 0000000000000000000000000000000000000000..52e26267089aff3d0ddbe9e4bd504ddd07ced6ae
--- /dev/null
+++ b/components/metrics/file_metrics_provider.cc
@@ -0,0 +1,234 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/metrics/file_metrics_provider.h"
+
+#include "base/command_line.h"
+#include "base/files/file.h"
+#include "base/files/file_util.h"
+#include "base/files/memory_mapped_file.h"
+#include "base/logging.h"
+#include "base/metrics/histogram_base.h"
+#include "base/metrics/histogram_persistence.h"
+#include "base/metrics/persistent_memory_allocator.h"
+#include "base/task_runner.h"
+#include "base/threading/worker_pool.h"
+#include "base/time/time.h"
+#include "components/metrics/metrics_pref_names.h"
+#include "components/metrics/metrics_service.h"
+#include "components/prefs/pref_registry_simple.h"
+#include "components/prefs/pref_service.h"
+
+namespace metrics {
+
+// This is fully defined in the header file (rather than just a forward
+// declaration) so it can be known to tests.
+struct FileMetricsProvider::FileInformation {
+ FileInformation();
+ ~FileInformation();
+
+ base::FilePath path; // Where on disk the file is located.
+ FileType type; // How to access this file (atomic/active).
+ std::string prefs_key; // Name used inside prefs to persistent metadata.
+ base::Time last_seen; // The last-seen time of this file to detect change.
+
+ // Once a file has been recognized as needing to be read, it is mapped into
+ // memory and assigned an allocator.
+ scoped_ptr<base::MemoryMappedFile> mapped;
+ scoped_ptr<base::PersistentMemoryAllocator> allocator;
+
+ // File I/O must not be done on the UI thread so these indicate objects that
+ // need to be released when doing the check on a provided task-runner.
+ scoped_ptr<base::MemoryMappedFile> file_to_release;
+ scoped_ptr<base::PersistentMemoryAllocator> allocator_to_release;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(FileInformation);
+};
+
+// Out-of-line constructor and destructor needed for code efficiency.
+FileMetricsProvider::FileInformation::FileInformation() {}
+FileMetricsProvider::FileInformation::~FileInformation() {}
+
+FileMetricsProvider::FileMetricsProvider(
+ const scoped_refptr<base::TaskRunner>& task_runner,
+ PrefService* local_state)
+ : weak_factory_(this),
+ task_runner_(task_runner),
+ pref_service_(local_state) {
+}
+
+FileMetricsProvider::~FileMetricsProvider() {
+}
+
+void FileMetricsProvider::RegisterFile(const base::FilePath& path,
+ FileType type,
+ const base::StringPiece& prefs_key) {
+ FileInformation* file = new FileInformation();
+ file->path = path;
+ file->type = type;
+ file->prefs_key = prefs_key.as_string();
+
+ if (pref_service_ && !prefs_key.empty()) {
+ file->last_seen = base::Time::FromInternalValue(
+ pref_service_->GetInt64(metrics::prefs::kMetricsLastSeenPrefix +
+ prefs_key.as_string()));
+ }
+
+ files_to_check_.push_back(make_scoped_ptr(file));
+}
+
+// static
+void FileMetricsProvider::RegisterPrefs(PrefRegistrySimple* prefs,
+ const base::StringPiece& key) {
+ prefs->RegisterInt64Pref(metrics::prefs::kMetricsLastSeenPrefix +
+ key.as_string(), 0);
+}
+
+// static
+void FileMetricsProvider::CheckAndMapNewMetricFilesOnTaskRunner(
+ FileMetricsProvider::FileInformationList* files) {
+ for (auto& file : *files)
+ CheckAndMapNewMetrics(file.get());
+}
+
+// static
+bool FileMetricsProvider::CheckAndMapNewMetrics(
+ FileMetricsProvider::FileInformation* file) {
+ DCHECK(!file->mapped);
+
+ // Un-mapping a file can only be done on an I/O thread which is why it is
+ // only marked "to release" with the actual release being done here.
+ file->file_to_release.reset();
+ file->allocator_to_release.reset();
+
+ base::File::Info info;
+ if (!base::GetFileInfo(file->path, &info) ||
+ info.is_directory || info.size == 0) {
+ return false;
+ }
+
+ if (file->last_seen >= info.last_modified)
+ return false;
+
+ // A new file of metrics has been found. Map it into memory.
+ file->mapped.reset(new base::MemoryMappedFile());
+ if (!file->mapped->Initialize(file->path)) {
+ NOTREACHED();
+ file->mapped.reset();
+ return false;
+ }
+ return true;
+}
+
+void FileMetricsProvider::ScheduleFilesCheck() {
+ if (files_to_check_.empty())
+ return;
+
+ FileInformationList* check_list = new FileInformationList();
+ std::swap(files_to_check_, *check_list);
+ task_runner_->PostTaskAndReply(
+ FROM_HERE,
+ base::Bind(&FileMetricsProvider::CheckAndMapNewMetricFilesOnTaskRunner,
+ base::Unretained(check_list)),
+ base::Bind(&FileMetricsProvider::RecordFilesChecked,
+ weak_factory_.GetWeakPtr(), base::Owned(check_list)));
+}
+
+void FileMetricsProvider::RecordFilesChecked(FileInformationList* checked) {
+ // Move each processed file to either the "to-read" list (for processing) or
+ // the "to-check" list (for future checking).
+ for (auto iter = checked->begin(); iter != checked->end();) {
+ auto temp = iter++;
+ const FileInformation* file = temp->get();
+ if (file->mapped)
+ files_to_read_.splice(files_to_read_.end(), *checked, temp);
+ else
+ files_to_check_.splice(files_to_check_.end(), *checked, temp);
+ }
+}
+
+void FileMetricsProvider::RecordFileAsSeen(FileInformation* file) {
+ file->last_seen = base::Time::Now();
+ if (pref_service_ && !file->prefs_key.empty()) {
+ pref_service_->SetInt64(metrics::prefs::kMetricsLastSeenPrefix +
+ file->prefs_key,
+ file->last_seen.ToInternalValue());
+ }
+}
+
+void FileMetricsProvider::OnDidCreateMetricsLog() {
+ // Move finished metric files back to list of monitored files.
+ for (auto iter = files_to_read_.begin(); iter != files_to_read_.end();) {
+ auto temp = iter++;
+ const FileInformation* file = temp->get();
+ if (!file->allocator && !file->mapped)
+ files_to_check_.splice(files_to_check_.end(), files_to_read_, temp);
+ }
+
+ // Schedule a check to see if there are new metrics to load. If so, they
+ // will be reported during the next collection run after this one. The
+ // check is run off of the worker-pool so as to not cause delays on the
+ // main UI thread (which is currently where metric collection is done).
+ ScheduleFilesCheck();
+}
+
+void FileMetricsProvider::RecordHistogramSnapshots(
+ base::HistogramSnapshotManager* hsm) {
+ for (auto& file : files_to_read_) {
+ // If the file is mapped then it needs to have an allocator attached to
+ // it in order to read histograms out of it.
+ if (file->mapped) {
+ DCHECK(!file->allocator);
+ DCHECK(!file->file_to_release);
+ DCHECK(!file->allocator_to_release);
+ if (!base::FilePersistentMemoryAllocator::IsFileAcceptable(
+ *file->mapped)) {
+ // Something is fundamentally wrong with the file. Ignore it.
+ LOG(ERROR) << "Metrics file \"" << file->path.value()
+ << "\" is not valid -- ignored.";
+ file->file_to_release.swap(file->mapped);
+ RecordFileAsSeen(file.get());
+ NOTREACHED();
+ continue;
+ }
+ file->allocator.reset(new base::FilePersistentMemoryAllocator(
+ std::move(file->mapped), 0, std::string()));
+ }
+
+ // A file should not be under "files to read" unless it has an allocator
+ // or is memory-mapped (at which point it will have received an allocator
+ // above). However, if this method gets called twice before the scheduled-
+ // files-check has a chance to clean up, this may trigger.
+ if (!file->allocator)
+ continue;
+
+ int histogram_count = 0;
+ base::PersistentMemoryAllocator::Iterator hist_iter;
+ file->allocator->CreateIterator(&hist_iter);
+ while (true) {
+ scoped_ptr<base::HistogramBase> histogram(
+ base::GetNextPersistentHistogram(file->allocator.get(), &hist_iter));
+ if (!histogram)
+ break;
+ if (file->type == FILE_HISTOGRAMS_ATOMIC)
+ hsm->PrepareOnceTakingOwnership(std::move(histogram));
+ else
+ hsm->PrepareDeltaTakingOwnership(std::move(histogram));
+ ++histogram_count;
+ }
+ DVLOG(1) << "Reported " << histogram_count << " histograms from "
+ << file->path.value();
+
+ if (file->type == FILE_HISTOGRAMS_ATOMIC) {
+ DCHECK(!file->mapped); // Ownership should have moved to allocator.
+ DCHECK(!file->file_to_release);
+ DCHECK(!file->allocator_to_release);
+ file->allocator_to_release.swap(file->allocator);
+ RecordFileAsSeen(file.get());
+ }
+ }
+}
+
+} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698