base/metrics/histogram_samples.cc - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_samples.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: test needs to clear out statistics-recorder before releasing histogram memory Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/histogram_persistence.cc ('K') | « base/metrics/histogram_persistence.cc ('k') | base/metrics/histogram_snapshot_manager.h » ('j') | base/metrics/histogram_snapshot_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/metrics/histogram_samples.cc

diff --git a/base/metrics/histogram_samples.cc b/base/metrics/histogram_samples.cc

index 4cd8e556b81c556dff9c2050348c47449c2d06c9..80b7b72e531d8cc98b56f3fe48a96d39c800eb59 100644

--- a/base/metrics/histogram_samples.cc

+++ b/base/metrics/histogram_samples.cc

@@ -73,7 +73,8 @@ HistogramSamples::HistogramSamples(uint64_t id)

HistogramSamples::HistogramSamples(uint64_t id, Metadata* meta)

: meta_(meta) {

DCHECK(meta_->id == 0 || meta_->id == id);

- meta_->id = id;

+ if (!meta_->id)

+ meta_->id = id;

}

HistogramSamples::~HistogramSamples() {}