Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: components/metrics/metrics_service.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: address (many) comments by Greg Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index 0b84dffbf361f48fe5554ade4e2139c78a666660..46dee9adcb995c34b761b203ed970e5e84cc45a7 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -1107,6 +1107,12 @@ void MetricsService::RecordCurrentEnvironment(MetricsLog* log) {
void MetricsService::RecordCurrentHistograms() {
DCHECK(log_manager_.current_log());
+ histogram_snapshot_manager_.StartDeltas();
+ for (size_t i = 0; i < metrics_providers_.size(); ++i) {
grt (UTC plus 2) 2016/02/08 18:09:19 will this work: for (auto& provider : metrics_pr
bcwhite 2016/02/09 21:08:46 Seems to work. I'll updated it elsewhere in the f
+ metrics_providers_[i]->RecordHistogramSnapshots(
+ &histogram_snapshot_manager_);
+ }
+ histogram_snapshot_manager_.FinishDeltas();
}
void MetricsService::RecordCurrentStabilityHistograms() {
« components/metrics/metrics_provider.h ('K') | « components/metrics/metrics_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698