Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: components/metrics/metrics_provider.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: address (many) comments by Greg Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_provider.h
diff --git a/components/metrics/metrics_provider.h b/components/metrics/metrics_provider.h
index 569b1e8fe185df71cfa0dd3ec37711acbbc6a453..77a64567f499463ec21ae923dcee5c0167d3f760 100644
--- a/components/metrics/metrics_provider.h
+++ b/components/metrics/metrics_provider.h
@@ -7,6 +7,12 @@
#include "base/macros.h"
+namespace base {
+
grt (UTC plus 2) 2016/02/08 18:09:19 nit: omit empty lines for a single forward decl li
bcwhite 2016/02/09 21:08:46 Done.
+class HistogramSnapshotManager;
+
+} // namespace base
+
namespace metrics {
class ChromeUserMetricsExtension;
@@ -63,6 +69,12 @@ class MetricsProvider {
virtual void ProvideGeneralMetrics(
ChromeUserMetricsExtension* uma_proto);
+ // Called during collection to explicitly load histogram snapshots using a
+ // snapshot manager. PrepareDeltas() will have been already called and
grt (UTC plus 2) 2016/02/08 18:09:19 nit "will have already been called"
bcwhite 2016/02/09 21:08:46 Done.
+ // FinishDeltas() will be called later; calls to only PrepareDelta(), not
+ // PrepareDeltas (plural), should be made.
+ virtual void RecordHistogramSnapshots(base::HistogramSnapshotManager* hsm);
+
private:
DISALLOW_COPY_AND_ASSIGN(MetricsProvider);
};

Powered by Google App Engine
This is Rietveld 408576698