chrome/installer/setup/installer_crash_reporting.cc - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/installer_crash_reporting.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: address (many) comments by Greg Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_metrics_service_client.cc ('K') | « chrome/installer/setup/BUILD.gn ('k') | chrome/installer/setup/installer_metrics.h » ('j') | chrome/installer/setup/installer_metrics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/setup/installer_crash_reporting.cc

diff --git a/chrome/installer/setup/installer_crash_reporting.cc b/chrome/installer/setup/installer_crash_reporting.cc

index fcecd773a729cf49d90e06bd4ba7facb0d938854..3bbedb8e8b62ee68096a43c7598072983ece2b5f 100644

--- a/chrome/installer/setup/installer_crash_reporting.cc

+++ b/chrome/installer/setup/installer_crash_reporting.cc

@@ -121,7 +121,11 @@ void ConfigureCrashReporting(const InstallerState& installer_state) {

size_t RegisterCrashKeys() {

const base::debug::CrashKey kFixedKeys[] = {

+#if defined(OS_MACOSX) || defined(OS_WIN)

+ { crash_keys::kMetricsClientId, crash_keys::kSmallSize },

+#else

{ crash_keys::kClientId, crash_keys::kSmallSize },

+#endif

{ kCurrentVersion, crash_keys::kSmallSize },

{ kDistributionType, crash_keys::kSmallSize },

{ kIsMultiInstall, crash_keys::kSmallSize },