Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: addressed final review comments by Alexei Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/metrics/histogram_snapshot_manager.cc ('k') | chrome/chrome_installer.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 5 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/callback.h" 12 #include "base/callback.h"
13 #include "base/command_line.h" 13 #include "base/command_line.h"
14 #include "base/files/file_path.h" 14 #include "base/files/file_path.h"
15 #include "base/logging.h" 15 #include "base/logging.h"
16 #include "base/metrics/histogram.h" 16 #include "base/metrics/histogram.h"
17 #include "base/path_service.h"
17 #include "base/rand_util.h" 18 #include "base/rand_util.h"
18 #include "base/strings/string16.h" 19 #include "base/strings/string16.h"
19 #include "base/threading/platform_thread.h" 20 #include "base/threading/platform_thread.h"
20 #include "build/build_config.h" 21 #include "build/build_config.h"
21 #include "chrome/browser/browser_process.h" 22 #include "chrome/browser/browser_process.h"
22 #include "chrome/browser/chrome_notification_types.h" 23 #include "chrome/browser/chrome_notification_types.h"
23 #include "chrome/browser/google/google_brand.h" 24 #include "chrome/browser/google/google_brand.h"
24 #include "chrome/browser/metrics/chrome_stability_metrics_provider.h" 25 #include "chrome/browser/metrics/chrome_stability_metrics_provider.h"
25 #include "chrome/browser/metrics/time_ticks_experiment_win.h" 26 #include "chrome/browser/metrics/time_ticks_experiment_win.h"
26 #include "chrome/browser/ui/browser_otr_state.h" 27 #include "chrome/browser/ui/browser_otr_state.h"
27 #include "chrome/common/channel_info.h" 28 #include "chrome/common/channel_info.h"
28 #include "chrome/common/chrome_constants.h" 29 #include "chrome/common/chrome_constants.h"
29 #include "chrome/common/chrome_paths.h" 30 #include "chrome/common/chrome_paths.h"
30 #include "chrome/common/chrome_switches.h" 31 #include "chrome/common/chrome_switches.h"
31 #include "chrome/common/crash_keys.h" 32 #include "chrome/common/crash_keys.h"
32 #include "chrome/common/features.h" 33 #include "chrome/common/features.h"
34 #include "chrome/installer/util/util_constants.h"
33 #include "components/metrics/call_stack_profile_metrics_provider.h" 35 #include "components/metrics/call_stack_profile_metrics_provider.h"
34 #include "components/metrics/drive_metrics_provider.h" 36 #include "components/metrics/drive_metrics_provider.h"
37 #include "components/metrics/file_metrics_provider.h"
35 #include "components/metrics/gpu/gpu_metrics_provider.h" 38 #include "components/metrics/gpu/gpu_metrics_provider.h"
36 #include "components/metrics/metrics_pref_names.h" 39 #include "components/metrics/metrics_pref_names.h"
37 #include "components/metrics/metrics_service.h" 40 #include "components/metrics/metrics_service.h"
38 #include "components/metrics/net/net_metrics_log_uploader.h" 41 #include "components/metrics/net/net_metrics_log_uploader.h"
39 #include "components/metrics/net/network_metrics_provider.h" 42 #include "components/metrics/net/network_metrics_provider.h"
40 #include "components/metrics/net/version_utils.h" 43 #include "components/metrics/net/version_utils.h"
41 #include "components/metrics/profiler/profiler_metrics_provider.h" 44 #include "components/metrics/profiler/profiler_metrics_provider.h"
42 #include "components/metrics/profiler/tracking_synchronizer.h" 45 #include "components/metrics/profiler/tracking_synchronizer.h"
43 #include "components/metrics/stability_metrics_helper.h" 46 #include "components/metrics/stability_metrics_helper.h"
44 #include "components/metrics/ui/screen_info_metrics_provider.h" 47 #include "components/metrics/ui/screen_info_metrics_provider.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 #if BUILDFLAG(ANDROID_JAVA_UI) 124 #if BUILDFLAG(ANDROID_JAVA_UI)
122 PrefService* local_state = g_browser_process->local_state(); 125 PrefService* local_state = g_browser_process->local_state();
123 return !local_state->HasPrefPath(metrics::prefs::kMetricsReportingEnabled) && 126 return !local_state->HasPrefPath(metrics::prefs::kMetricsReportingEnabled) &&
124 variations::GetVariationParamValue("UMA_EnableCellularLogUpload", 127 variations::GetVariationParamValue("UMA_EnableCellularLogUpload",
125 "Enabled") == "true"; 128 "Enabled") == "true";
126 #else 129 #else
127 return false; 130 return false;
128 #endif 131 #endif
129 } 132 }
130 133
134 void RegisterInstallerFileMetricsPreferences(PrefRegistrySimple* registry) {
135 #if defined(OS_WIN)
136 metrics::FileMetricsProvider::RegisterPrefs(
137 registry, installer::kSetupHistogramAllocatorName);
138 #endif
139 }
140
141 void RegisterInstallerFileMetricsProvider(
142 metrics::MetricsService* metrics_service) {
143 #if defined(OS_WIN)
144 scoped_ptr<metrics::FileMetricsProvider> file_metrics(
145 new metrics::FileMetricsProvider(
146 content::BrowserThread::GetBlockingPool()
147 ->GetTaskRunnerWithShutdownBehavior(
148 base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN),
149 g_browser_process->local_state()));
150 base::FilePath program_dir;
151 base::PathService::Get(base::DIR_EXE, &program_dir);
152 file_metrics->RegisterFile(
153 program_dir.AppendASCII(installer::kSetupHistogramAllocatorName)
154 .AddExtension(L".pma"),
155 metrics::FileMetricsProvider::FILE_HISTOGRAMS_ATOMIC,
156 installer::kSetupHistogramAllocatorName);
157 metrics_service->RegisterMetricsProvider(std::move(file_metrics));
158 #endif
159 }
160
131 } // namespace 161 } // namespace
132 162
133 163
134 ChromeMetricsServiceClient::ChromeMetricsServiceClient( 164 ChromeMetricsServiceClient::ChromeMetricsServiceClient(
135 metrics::MetricsStateManager* state_manager) 165 metrics::MetricsStateManager* state_manager)
136 : metrics_state_manager_(state_manager), 166 : metrics_state_manager_(state_manager),
137 #if defined(OS_CHROMEOS) 167 #if defined(OS_CHROMEOS)
138 chromeos_metrics_provider_(nullptr), 168 chromeos_metrics_provider_(nullptr),
139 #endif 169 #endif
140 waiting_for_collect_final_metrics_step_(false), 170 waiting_for_collect_final_metrics_step_(false),
(...skipping 29 matching lines...) Expand all
170 client->Initialize(); 200 client->Initialize();
171 201
172 return client; 202 return client;
173 } 203 }
174 204
175 // static 205 // static
176 void ChromeMetricsServiceClient::RegisterPrefs(PrefRegistrySimple* registry) { 206 void ChromeMetricsServiceClient::RegisterPrefs(PrefRegistrySimple* registry) {
177 metrics::MetricsService::RegisterPrefs(registry); 207 metrics::MetricsService::RegisterPrefs(registry);
178 metrics::StabilityMetricsHelper::RegisterPrefs(registry); 208 metrics::StabilityMetricsHelper::RegisterPrefs(registry);
179 209
210 RegisterInstallerFileMetricsPreferences(registry);
211
180 #if BUILDFLAG(ANDROID_JAVA_UI) 212 #if BUILDFLAG(ANDROID_JAVA_UI)
181 AndroidMetricsProvider::RegisterPrefs(registry); 213 AndroidMetricsProvider::RegisterPrefs(registry);
182 #endif // BUILDFLAG(ANDROID_JAVA_UI) 214 #endif // BUILDFLAG(ANDROID_JAVA_UI)
183 215
184 #if defined(ENABLE_PLUGINS) 216 #if defined(ENABLE_PLUGINS)
185 PluginMetricsProvider::RegisterPrefs(registry); 217 PluginMetricsProvider::RegisterPrefs(registry);
186 #endif // defined(ENABLE_PLUGINS) 218 #endif // defined(ENABLE_PLUGINS)
187 } 219 }
188 220
189 metrics::MetricsService* ChromeMetricsServiceClient::GetMetricsService() { 221 metrics::MetricsService* ChromeMetricsServiceClient::GetMetricsService() {
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 base::Bind(&chrome::IsOffTheRecordSessionActive)))); 360 base::Bind(&chrome::IsOffTheRecordSessionActive))));
329 metrics_service_->RegisterMetricsProvider( 361 metrics_service_->RegisterMetricsProvider(
330 scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider( 362 scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider(
331 g_browser_process->local_state()))); 363 g_browser_process->local_state())));
332 metrics_service_->RegisterMetricsProvider( 364 metrics_service_->RegisterMetricsProvider(
333 scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider)); 365 scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider));
334 metrics_service_->RegisterMetricsProvider( 366 metrics_service_->RegisterMetricsProvider(
335 scoped_ptr<metrics::MetricsProvider>( 367 scoped_ptr<metrics::MetricsProvider>(
336 new metrics::ScreenInfoMetricsProvider)); 368 new metrics::ScreenInfoMetricsProvider));
337 369
370 RegisterInstallerFileMetricsProvider(metrics_service_.get());
371
338 drive_metrics_provider_ = new metrics::DriveMetricsProvider( 372 drive_metrics_provider_ = new metrics::DriveMetricsProvider(
339 content::BrowserThread::GetMessageLoopProxyForThread( 373 content::BrowserThread::GetMessageLoopProxyForThread(
340 content::BrowserThread::FILE), 374 content::BrowserThread::FILE),
341 chrome::FILE_LOCAL_STATE); 375 chrome::FILE_LOCAL_STATE);
342 metrics_service_->RegisterMetricsProvider( 376 metrics_service_->RegisterMetricsProvider(
343 scoped_ptr<metrics::MetricsProvider>(drive_metrics_provider_)); 377 scoped_ptr<metrics::MetricsProvider>(drive_metrics_provider_));
344 378
345 profiler_metrics_provider_ = 379 profiler_metrics_provider_ =
346 new metrics::ProfilerMetricsProvider(base::Bind(&IsCellularLogicEnabled)); 380 new metrics::ProfilerMetricsProvider(base::Bind(&IsCellularLogicEnabled));
347 metrics_service_->RegisterMetricsProvider( 381 metrics_service_->RegisterMetricsProvider(
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 if (!ServiceProcessControl::GetInstance()->GetHistograms(callback, timeout)) { 550 if (!ServiceProcessControl::GetInstance()->GetHistograms(callback, timeout)) {
517 // Assume |num_async_histogram_fetches_in_progress_| is not changed by 551 // Assume |num_async_histogram_fetches_in_progress_| is not changed by
518 // |GetHistograms()|. 552 // |GetHistograms()|.
519 DCHECK_EQ(num_async_histogram_fetches_in_progress_, 2); 553 DCHECK_EQ(num_async_histogram_fetches_in_progress_, 2);
520 // Assign |num_async_histogram_fetches_in_progress_| above and decrement it 554 // Assign |num_async_histogram_fetches_in_progress_| above and decrement it
521 // here to make code work even if |GetHistograms()| fired |callback|. 555 // here to make code work even if |GetHistograms()| fired |callback|.
522 --num_async_histogram_fetches_in_progress_; 556 --num_async_histogram_fetches_in_progress_;
523 } 557 }
524 #endif // !ENABLE_PRINT_PREVIEW 558 #endif // !ENABLE_PRINT_PREVIEW
525 559
526 // Set up the callback to task to call after we receive histograms from all 560 // Set up the callback task to call after we receive histograms from all
527 // child processes. |timeout| specifies how long to wait before absolutely 561 // child processes. |timeout| specifies how long to wait before absolutely
528 // calling us back on the task. 562 // calling us back on the task.
529 content::FetchHistogramsAsynchronously(base::MessageLoop::current(), callback, 563 content::FetchHistogramsAsynchronously(base::MessageLoop::current(), callback,
530 timeout); 564 timeout);
531 } 565 }
532 566
533 void ChromeMetricsServiceClient::OnHistogramSynchronizationDone() { 567 void ChromeMetricsServiceClient::OnHistogramSynchronizationDone() {
534 DCHECK(thread_checker_.CalledOnValidThread()); 568 DCHECK(thread_checker_.CalledOnValidThread());
535 569
536 // This function should only be called as the callback from an ansynchronous 570 // This function should only be called as the callback from an ansynchronous
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 break; 645 break;
612 646
613 default: 647 default:
614 NOTREACHED(); 648 NOTREACHED();
615 } 649 }
616 } 650 }
617 651
618 void ChromeMetricsServiceClient::OnURLOpenedFromOmnibox(OmniboxLog* log) { 652 void ChromeMetricsServiceClient::OnURLOpenedFromOmnibox(OmniboxLog* log) {
619 metrics_service_->OnApplicationNotIdle(); 653 metrics_service_->OnApplicationNotIdle();
620 } 654 }
OLDNEW
« no previous file with comments | « base/metrics/histogram_snapshot_manager.cc ('k') | chrome/chrome_installer.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698