components/metrics/metrics_provider.cc - Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/metrics/metrics_provider.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: addressed review comments by Greg Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/metrics/metrics_provider.h ('K') | « components/metrics/metrics_provider.h ('k') | components/metrics/metrics_service.cc » ('j') | components/metrics/metrics_service.cc » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/metrics/metrics_provider.h"	5 #include "components/metrics/metrics_provider.h"

6	6

7 namespace metrics {	7 namespace metrics {

8	8

9 MetricsProvider::MetricsProvider() {	9 MetricsProvider::MetricsProvider() {

10 }	10 }

(...skipping 26 matching lines...) Expand all Loading...
37 SystemProfileProto* system_profile_proto) {	37 SystemProfileProto* system_profile_proto) {

38 }	38 }

39	39

40 void MetricsProvider::ClearSavedStabilityMetrics() {	40 void MetricsProvider::ClearSavedStabilityMetrics() {

41 }	41 }

42	42

43 void MetricsProvider::ProvideGeneralMetrics(	43 void MetricsProvider::ProvideGeneralMetrics(

44 ChromeUserMetricsExtension* uma_proto) {	44 ChromeUserMetricsExtension* uma_proto) {

45 }	45 }

46	46

	47 void MetricsProvider::RecordHistogramSnapshots(

	48 base::HistogramSnapshotManager* hsm) {
	Alexei Svitkine (slow) 2016/02/17 21:55:36 Nit: snapshot_manager Nit: snapshot_manager bcwhite 2016/02/18 01:46:57 Done. Show quoted text On 2016/02/17 21:55:36, Alexei Svitkine wrote: > Nit: snapshot_manager Done.
	49 }

	50

47 } // namespace metrics	51 } // namespace metrics

OLD	NEW