Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/installer/setup/installer_metrics.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: test needs to clear out statistics-recorder before releasing histogram memory Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/installer/setup/installer_metrics.h"
6
7 #include "base/files/file.h"
8 #include "base/files/file_path.h"
9 #include "base/files/file_util.h"
10 #include "base/metrics/histogram_base.h"
11 #include "base/metrics/histogram_persistence.h"
12 #include "base/metrics/persistent_memory_allocator.h"
13 #include "chrome/installer/util/util_constants.h"
14
15 namespace installer {
16
17 void BeginPersistentHistogramStorage() {
18 base::SetPersistentHistogramMemoryAllocator(
19 new base::LocalPersistentMemoryAllocator(
20 1 << 20, 0, // 1 MiB
21 installer::kSetupHistogramAllocatorName));
22 base::GetPersistentHistogramMemoryAllocator()->CreateTrackingHistograms(
23 installer::kSetupHistogramAllocatorName);
24 }
25
26 void EndPersistentHistogramStorage(const base::FilePath& target_path) {
27 // For atomicity, first write to a temporary file and then rename it.
28 // The ImportantFileWriter would be good for this except it supports only
29 // std::string for its data.
30 base::PersistentMemoryAllocator* allocator =
31 base::GetPersistentHistogramMemoryAllocator();
32 allocator->UpdateTrackingHistograms();
33
34 base::FilePath file_path = target_path
35 .AppendASCII(allocator->Name())
36 .AddExtension(L".pma");
37 base::FilePath tmp_file_path;
38 base::DeleteFile(file_path, false);
39
40 if (base::CreateTemporaryFileInDir(file_path.DirName(), &tmp_file_path)) {
41 base::File histograms(tmp_file_path,
42 base::File::FLAG_OPEN | base::File::FLAG_WRITE);
43 if (histograms.IsValid()) {
44 // Allocator doesn't support more than 2GB so can never overflow.
grt (UTC plus 2) 2016/02/15 15:42:39 1GB? (kSegmentMaxSize is 1 << 30)
bcwhite 2016/02/15 19:22:10 Still technically true! :-D Done.
45 int used = static_cast<int>(allocator->used());
46 if (histograms.Write(0, static_cast<const char*>(allocator->data()),
47 used) == used &&
48 histograms.Flush()) {
49 histograms.Close();
50 if (base::ReplaceFile(tmp_file_path, file_path, nullptr)) {
51 VLOG(1) << "Persistent histograms saved in file: "
52 << file_path.value();
53 }
54 }
55 histograms.Close();
56 }
57 base::DeleteFile(tmp_file_path, false);
58 }
59 }
60
61 } // namespace installer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698